This repository has been archived by the owner on Jul 24, 2021. It is now read-only.
deprecate legacy validation endpoints #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenetheridge
added
api
breaking
needs-shell
karenetheridge
force-pushed
the
ether/legacy-validation-endpoints
branch
6 times, most recently
from
432ba4c
to
d50cc1d
Compare
dustinryerson
previously approved these changes
Nov 2, 2020
All relevant information is already denormalized into GET /device/:id/validation_state. ..and rename associated json schemas to s/^/Legacy/. Database tables will be renamed in v3.3.
- POST /device/:device_id/validation/:validation_id - POST /device/:device_id/validation_plan/:validation_plan_id
… in v3.1 in endpoints: - POST /device_report - POST /device/:id_or_serial_number/validation_plan/:validation_plan_id - POST /device/:id_or_serial_number/validation/:validation_id - GET /device/:id_or_serial_number/validation_state It is redundant information as all the validation_ids are included with the individual results.
..and rename schemas to s/^/Legacy/. Database tables will be renamed in v3.3.
They are not deprecated as we will likely still be returning them in responses some of the time, even after v4.0, when considering devices that have not seen recent device reports.
perigrin
previously approved these changes
Nov 10, 2020
karenetheridge
dismissed stale reviews from perigrin and dustinryerson
via
db2e313
karenetheridge
force-pushed
the
ether/legacy-validation-endpoints
branch
from
d50cc1d
to
db2e313
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing is removed yet, but clients should be getting off these endpoints/relying on these properties ASAP.