Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

deprecate legacy validation endpoints #1056

Merged
merged 7 commits into from
Nov 10, 2020
Merged

deprecate legacy validation endpoints #1056

merged 7 commits into from
Nov 10, 2020

Commits on Nov 2, 2020

  1. move /validation_plan and /validation_state routes off to their own f… 

    …iles
    @karenetheridge
    karenetheridge committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    5d63aa6 View commit details
    Browse the repository at this point in the history

  2. deprecate GET /validation and GET /validation/:id, to be removed in v3.1 

    All relevant information is already denormalized into GET /device/:id/validation_state.

..and rename associated json schemas to s/^/Legacy/.
Database tables will be renamed in v3.3.
    @karenetheridge
    karenetheridge committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    2a74546 View commit details
    Browse the repository at this point in the history

  3. deprecate old "test validation" endpoints, to be removed in v4.0 

    - POST /device/:device_id/validation/:validation_id
- POST /device/:device_id/validation_plan/:validation_plan_id
    @karenetheridge
    karenetheridge committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    9860ff9 View commit details
    Browse the repository at this point in the history

  4. hardware_product.validation_plan_id is deprecated and will be removed… 

    … soon
    @karenetheridge
    karenetheridge committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    7cf1f50 View commit details
    Browse the repository at this point in the history

  5. "validation_plan_id" property will be removed from validation results… 

    … in v3.1

in endpoints:
- POST /device_report
- POST /device/:id_or_serial_number/validation_plan/:validation_plan_id
- POST /device/:id_or_serial_number/validation/:validation_id
- GET /device/:id_or_serial_number/validation_state

It is redundant information as all the validation_ids are included with the
individual results.
    @karenetheridge
    karenetheridge committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    3eba9b7 View commit details
    Browse the repository at this point in the history

  6. deprecate all /validation_plan routes, to be removed in v4.0 

    ..and rename schemas to s/^/Legacy/.
Database tables will be renamed in v3.3.
    @karenetheridge
    karenetheridge committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    2012639 View commit details
    Browse the repository at this point in the history

  7. rename validation result json schemas as s/^/Legacy/. 

    They are not deprecated as we will likely still be returning them in
responses some of the time, even after v4.0, when considering devices that
have not seen recent device reports.
    @karenetheridge
    karenetheridge committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    db2e313 View commit details
    Browse the repository at this point in the history