-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exclusive control to File.contents
and File.lines
#502
Conversation
👍 with a changelog entry |
} | ||
return _contents! | ||
} | ||
set { | ||
_contents = newValue | ||
_contentsQueue.sync { | ||
_contents = newValue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this also invalidate _lines
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right.
I'll make additional changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch Sam 👍
Could you please review again? |
File.lines.getter
onxcodebuild test -enableThreadSanitizer YES
realm/SwiftLint#2089File.lines:setter