Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThreadSanitizer reports data race at File.lines.getter on xcodebuild test -enableThreadSanitizer YES #2089

Closed
norio-nomura opened this issue Mar 8, 2018 · 5 comments
Closed

ThreadSanitizer reports data race at File.lines.getter on xcodebuild test -enableThreadSanitizer YES #2089

norio-nomura opened this issue Mar 8, 2018 · 5 comments

Comments

@norio-nomura
Copy link
Collaborator 

$ DEVELOPER_DIR=/Applications/Xcode.app xcodebuild -workspace SwiftLint.xcworkspace/ -scheme swiftlint -enableThreadSanitizer YES test -only-testing:SwiftLintFrameworkTests/IntegrationTests/testSwiftLintLints
…
Test Case '-[SwiftLintFrameworkTests.IntegrationTests testSwiftLintLints]' started.
Loading configuration from '.swiftlint.yml'
==================
WARNING: ThreadSanitizer: data race (pid=32964)
  Read of size 8 at 0x7b1800019310 by main thread:
  * #0 File.lines.getter File.swift:37 (SourceKittenFramework:x86_64+0x3c537)
    #1 TrailingWhitespaceRule.validate(file:) TrailingWhitespaceRule.swift:32 (SwiftLintFramework:x86_64+0x4be08c)
    #2 protocol witness for Rule.validate(file:) in conformance TrailingWhitespaceRule TrailingWhitespaceRule.swift (SwiftLintFramework:x86_64+0x4c2d80)
    #3 Rule.lint(file:regions:benchmark:superfluousDisableCommandRule:) Linter.swift:71 (SwiftLintFramework:x86_64+0xc1119)
    #4 closure #2 in Linter.getStyleViolations(benchmark:) Linter.swift:138 (SwiftLintFramework:x86_64+0xd3acc)
    #5 partial apply for closure #2 in Linter.getStyleViolations(benchmark:) Linter.swift (SwiftLintFramework:x86_64+0xdc5dc)
    #6 thunk for @callee_owned (@in Rule) -> (@owned LintResult?) Linter.swift (SwiftLintFramework:x86_64+0xd3d9a)
    #7 partial apply for thunk for @callee_owned (@in Rule) -> (@owned LintResult?) Linter.swift (SwiftLintFramework:x86_64+0xdc6c9)
    #8 closure #1 in Array.parallelMap<A>(transform:) Array+SwiftLint.swift:67 (SwiftLintFramework:x86_64+0x4a966e)
    #9 partial apply for closure #1 in Array.parallelMap<A>(transform:) Array+SwiftLint.swift (SwiftLintFramework:x86_64+0x4a99c4)
    #10 thunk for @callee_owned (@unowned Int) -> () <null> (libswiftDispatch.dylib:x86_64+0xb5a6)
    #11 _dispatch_client_callout2 <null> (libdispatch.dylib:x86_64+0xc167)
    #12 _swift_dispatch_apply_current <null> (libswiftDispatch.dylib:x86_64+0x12f51)
    #13 Array.parallelFlatMap<A>(transform:) Array+SwiftLint.swift:59 (SwiftLintFramework:x86_64+0x4a91b5)
    #14 Linter.getStyleViolations(benchmark:) Linter.swift:139 (SwiftLintFramework:x86_64+0xcfa8b)
    #15 Linter.styleViolations.getter Linter.swift:116 (SwiftLintFramework:x86_64+0xce74f)
    #16 closure #2 in IntegrationTests.testSwiftLintLints() IntegrationTests.swift:31 (SwiftLintFrameworkTests:x86_64+0x1692b)
    #17 thunk for @callee_owned (@owned File) -> (@owned [StyleViolation], @error @owned Error) IntegrationTests.swift (SwiftLintFrameworkTests:x86_64+0x16ae1)
    #18 partial apply for thunk for @callee_owned (@owned File) -> (@owned [StyleViolation], @error @owned Error) IntegrationTests.swift (SwiftLintFrameworkTests:x86_64+0x16c5a)
    #19 Sequence.flatMap<A>(_:) <null> (libswiftCore.dylib:x86_64+0x15f752)
    #20 @objc IntegrationTests.testSwiftLintLints() IntegrationTests.swift (SwiftLintFrameworkTests:x86_64+0x18930)
    #21 __invoking___ <null> (CoreFoundation:x86_64h+0x829db)

  Previous write of size 8 at 0x7b1800019310 by thread T4 (mutexes: write M2476):
  * #0 File.lines.getter File.swift:38 (SourceKittenFramework:x86_64+0x3c682)
    #1 File.syntaxTokensByLine() File+SwiftLint.swift:155 (SwiftLintFramework:x86_64+0x29f721)
    #2 closure #1 in variable initialization expression of syntaxTokensByLinesCache File+Cache.swift:31 (SwiftLintFramework:x86_64+0x27d869)
    #3 thunk for @callee_owned (@owned File) -> (@owned [[SyntaxToken]]?) File+Cache.swift (SwiftLintFramework:x86_64+0x27d8e3)
    #4 partial apply for thunk for @callee_owned (@owned File) -> (@owned [[SyntaxToken]]?) File+Cache.swift (SwiftLintFramework:x86_64+0x2834f9)
    #5 Cache.get(_:) File+Cache.swift:73 (SwiftLintFramework:x86_64+0x27f132)
    #6 File.syntaxTokensByLines.getter File+Cache.swift:152 (SwiftLintFramework:x86_64+0x281a48)
    #7 ClosureSpacingRule.validBraces(in:) ClosureSpacingRule.swift:84 (SwiftLintFramework:x86_64+0x447b72)
    #8 ClosureSpacingRule.findViolations(file:) ClosureSpacingRule.swift:129 (SwiftLintFramework:x86_64+0x449b09)
    #9 ClosureSpacingRule.validate(file:) ClosureSpacingRule.swift:146 (SwiftLintFramework:x86_64+0x44b91a)
    #10 protocol witness for Rule.validate(file:) in conformance ClosureSpacingRule ClosureSpacingRule.swift (SwiftLintFramework:x86_64+0x44f874)
    #11 Rule.lint(file:regions:benchmark:superfluousDisableCommandRule:) Linter.swift:71 (SwiftLintFramework:x86_64+0xc1119)
    #12 closure #2 in Linter.getStyleViolations(benchmark:) Linter.swift:138 (SwiftLintFramework:x86_64+0xd3acc)
    #13 partial apply for closure #2 in Linter.getStyleViolations(benchmark:) Linter.swift (SwiftLintFramework:x86_64+0xdc5dc)
    #14 thunk for @callee_owned (@in Rule) -> (@owned LintResult?) Linter.swift (SwiftLintFramework:x86_64+0xd3d9a)
    #15 partial apply for thunk for @callee_owned (@in Rule) -> (@owned LintResult?) Linter.swift (SwiftLintFramework:x86_64+0xdc6c9)
    #16 closure #1 in Array.parallelMap<A>(transform:) Array+SwiftLint.swift:67 (SwiftLintFramework:x86_64+0x4a966e)
    #17 partial apply for closure #1 in Array.parallelMap<A>(transform:) Array+SwiftLint.swift (SwiftLintFramework:x86_64+0x4a99c4)
    #18 thunk for @callee_owned (@unowned Int) -> () <null> (libswiftDispatch.dylib:x86_64+0xb5a6)
    #19 _dispatch_client_callout2 <null> (libdispatch.dylib:x86_64+0xc167)

  Issue is caused by frames marked with "*".

  Location is heap block of size 88 at 0x7b18000192c0 allocated by main thread:
    #0 malloc <null> (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x48b3a)
    #1 swift_slowAlloc <null> (libswiftCore.dylib:x86_64+0x344478)
    #2 File.__allocating_init(pathDeferringReading:) File.swift (SourceKittenFramework:x86_64+0x3d6cc)
    #3 partial apply for File.__allocating_init(pathDeferringReading:) Configuration+LintableFiles.swift (SwiftLintFramework:x86_64+0x2d303e)
    #4 thunk for @callee_owned (@owned String) -> (@owned File?, @error @owned Error) Configuration+LintableFiles.swift (SwiftLintFramework:x86_64+0x2d0d29)
    #5 partial apply for thunk for @callee_owned (@owned String) -> (@owned File?, @error @owned Error) Configuration+LintableFiles.swift (SwiftLintFramework:x86_64+0x2d0eaa)
    #6 Sequence.flatMap<A>(_:) <null> (libswiftCore.dylib:x86_64+0x15fa87)
    #7 IntegrationTests.testSwiftLintLints() IntegrationTests.swift:27 (SwiftLintFrameworkTests:x86_64+0x15514)
    #8 @objc IntegrationTests.testSwiftLintLints() IntegrationTests.swift (SwiftLintFrameworkTests:x86_64+0x18930)
    #9 __invoking___ <null> (CoreFoundation:x86_64h+0x829db)

  Mutex M2476 (0x7b18000066d0) created at:
    #0 pthread_mutex_init <null> (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2b213)
    #1 -[NSLock init] <null> (Foundation:x86_64+0x1d7d)
    #2 NSLock.__allocating_init() Configuration+Cache.swift (SwiftLintFramework:x86_64+0x26d1f4)
    #3 Cache.init(_:) File+Cache.swift:60 (SwiftLintFramework:x86_64+0x27ead7)
    #4 Cache.__allocating_init(_:) File+Cache.swift (SwiftLintFramework:x86_64+0x27c0eb)
    #5 globalinit_33_D93545007D2CCCB97554C3EFBF0F3773_func4 File+Cache.swift:31 (SwiftLintFramework:x86_64+0x27d7f2)
    #6 dispatch_once <null> (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x66e04)
    #7 dispatch_once_f <null> (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x66ef6)
    #8 syntaxTokensByLinesCache.unsafeMutableAddressor File+Cache.swift:31 (SwiftLintFramework:x86_64+0x27d969)
    #9 File.syntaxTokensByLines.getter File+Cache.swift:152 (SwiftLintFramework:x86_64+0x2819e7)
    #10 ClosureSpacingRule.validBraces(in:) ClosureSpacingRule.swift:84 (SwiftLintFramework:x86_64+0x447b72)
    #11 ClosureSpacingRule.findViolations(file:) ClosureSpacingRule.swift:129 (SwiftLintFramework:x86_64+0x449b09)
    #12 ClosureSpacingRule.validate(file:) ClosureSpacingRule.swift:146 (SwiftLintFramework:x86_64+0x44b91a)
    #13 protocol witness for Rule.validate(file:) in conformance ClosureSpacingRule ClosureSpacingRule.swift (SwiftLintFramework:x86_64+0x44f874)
    #14 Rule.lint(file:regions:benchmark:superfluousDisableCommandRule:) Linter.swift:71 (SwiftLintFramework:x86_64+0xc1119)
    #15 closure #2 in Linter.getStyleViolations(benchmark:) Linter.swift:138 (SwiftLintFramework:x86_64+0xd3acc)
    #16 partial apply for closure #2 in Linter.getStyleViolations(benchmark:) Linter.swift (SwiftLintFramework:x86_64+0xdc5dc)
    #17 thunk for @callee_owned (@in Rule) -> (@owned LintResult?) Linter.swift (SwiftLintFramework:x86_64+0xd3d9a)
    #18 partial apply for thunk for @callee_owned (@in Rule) -> (@owned LintResult?) Linter.swift (SwiftLintFramework:x86_64+0xdc6c9)
    #19 closure #1 in Array.parallelMap<A>(transform:) Array+SwiftLint.swift:67 (SwiftLintFramework:x86_64+0x4a966e)
    #20 partial apply for closure #1 in Array.parallelMap<A>(transform:) Array+SwiftLint.swift (SwiftLintFramework:x86_64+0x4a99c4)
    #21 thunk for @callee_owned (@unowned Int) -> () <null> (libswiftDispatch.dylib:x86_64+0xb5a6)
    #22 _dispatch_client_callout2 <null> (libdispatch.dylib:x86_64+0xc167)

  Thread T4 (tid=710935, running) is a GCD worker thread

SUMMARY: ThreadSanitizer: data race File.swift:37 in File.lines.getter
…
@norio-nomura norio-nomura mentioned this issue Mar 8, 2018
Merged
@jpsim
Copy link
Collaborator

jpsim commented Mar 8, 2018

Fixed in #2090

@jpsim jpsim closed this as completed Mar 8, 2018
@norio-nomura
Copy link
Collaborator Author

Sorry, I did not think that this issue will be fixed in #2090.
I'll open another PR for fixing this.

@norio-nomura norio-nomura reopened this Mar 8, 2018
@norio-nomura norio-nomura mentioned this issue Mar 9, 2018
Merged
@jpsim
Copy link
Collaborator

jpsim commented Mar 9, 2018

I see. Thanks!

@norio-nomura
Copy link
Collaborator Author

I understand why it did not occur in the tsan job of CircleCI which existed before.
It does not occur when linting multiple files in parallel.
This issue could also be reproduced by linting single file with swift run.

$ swift run -Xswiftc -sanitize=thread swiftlint lint --lenient --no-cache --path Package.swift
Loading configuration from '.swiftlint.yml'
Linting Swift files at path Package.swift
Linting 'Package.swift' (1/1)
==================
WARNING: ThreadSanitizer: data race (pid=38440)
  Read of size 8 at 0x7b1800006590 by thread T5:
  * #0 File.lines.getter File.swift:37 (swiftlint:x86_64+0x1000e6136)
    #1 TrailingWhitespaceRule.validate(file:) TrailingWhitespaceRule.swift:32 (swiftlint:x86_64+0x1006b82fb)
    #2 protocol witness for Rule.validate(file:) in conformance TrailingWhitespaceRule TrailingWhitespaceRule.swift (swiftlint:x86_64+0x1006bceb0)
    #3 Rule.lint(file:regions:benchmark:superfluousDisableCommandRule:) Linter.swift:71 (swiftlint:x86_64+0x1002bc733)
    #4 closure #2 in Linter.getStyleViolations(benchmark:) Linter.swift:138 (swiftlint:x86_64+0x1002cef1b)
    #5 partial apply for closure #2 in Linter.getStyleViolations(benchmark:) Linter.swift (swiftlint:x86_64+0x1002d785c)
    #6 thunk for @callee_owned (@in Rule) -> (@owned LintResult?) Linter.swift (swiftlint:x86_64+0x1002cf1ea)
    #7 partial apply for thunk for @callee_owned (@in Rule) -> (@owned LintResult?) Linter.swift (swiftlint:x86_64+0x1002d7949)
    #8 closure #1 in closure #1 in Array.parallelMap<A>(transform:) Array+SwiftLint.swift:66 (swiftlint:x86_64+0x100214779)
    #9 partial apply for closure #1 in closure #1 in Array.parallelMap<A>(transform:) Array+SwiftLint.swift (swiftlint:x86_64+0x100214f51)
    #10 thunk for @callee_owned (@unowned Int) -> () <null>:3204080 (libswiftDispatch.dylib:x86_64+0xb5a6)
    #11 _dispatch_client_callout2 <null>:3204080 (libdispatch.dylib:x86_64+0xc167)

  Previous write of size 8 at 0x7b1800006590 by thread T6 (mutexes: write M1368):
  * #0 File.lines.getter File.swift:38 (swiftlint:x86_64+0x1000e6270)
    #1 File.syntaxTokensByLine() File+SwiftLint.swift:155 (swiftlint:x86_64+0x1002643fe)
    #2 closure #1 in variable initialization expression of syntaxTokensByLinesCache File+Cache.swift:31 (swiftlint:x86_64+0x100250a89)
    #3 thunk for @callee_owned (@owned File) -> (@owned [[SyntaxToken]]?) File+Cache.swift (swiftlint:x86_64+0x100250b03)
    #4 partial apply for thunk for @callee_owned (@owned File) -> (@owned [[SyntaxToken]]?) File+Cache.swift (swiftlint:x86_64+0x100256529)
    #5 Cache.get(_:) File+Cache.swift:73 (swiftlint:x86_64+0x1002522f7)
    #6 File.syntaxTokensByLines.getter File+Cache.swift:152 (swiftlint:x86_64+0x100254a06)
    #7 ClosureSpacingRule.validBraces(in:) ClosureSpacingRule.swift:84 (swiftlint:x86_64+0x1003824c1)
    #8 ClosureSpacingRule.findViolations(file:) ClosureSpacingRule.swift:129 (swiftlint:x86_64+0x1003843b8)
    #9 ClosureSpacingRule.validate(file:) ClosureSpacingRule.swift:146 (swiftlint:x86_64+0x1003860d9)
    #10 protocol witness for Rule.validate(file:) in conformance ClosureSpacingRule ClosureSpacingRule.swift (swiftlint:x86_64+0x10038aea4)
    #11 Rule.lint(file:regions:benchmark:superfluousDisableCommandRule:) Linter.swift:71 (swiftlint:x86_64+0x1002bc733)
    #12 closure #2 in Linter.getStyleViolations(benchmark:) Linter.swift:138 (swiftlint:x86_64+0x1002cef1b)
    #13 partial apply for closure #2 in Linter.getStyleViolations(benchmark:) Linter.swift (swiftlint:x86_64+0x1002d785c)
    #14 thunk for @callee_owned (@in Rule) -> (@owned LintResult?) Linter.swift (swiftlint:x86_64+0x1002cf1ea)
    #15 partial apply for thunk for @callee_owned (@in Rule) -> (@owned LintResult?) Linter.swift (swiftlint:x86_64+0x1002d7949)
    #16 closure #1 in closure #1 in Array.parallelMap<A>(transform:) Array+SwiftLint.swift:66 (swiftlint:x86_64+0x100214779)
    #17 partial apply for closure #1 in closure #1 in Array.parallelMap<A>(transform:) Array+SwiftLint.swift (swiftlint:x86_64+0x100214f51)
    #18 thunk for @callee_owned (@unowned Int) -> () <null>:3204080 (libswiftDispatch.dylib:x86_64+0xb5a6)
    #19 _dispatch_client_callout2 <null>:3204080 (libdispatch.dylib:x86_64+0xc167)

  Issue is caused by frames marked with "*".

  Location is heap block of size 88 at 0x7b1800006540 allocated by thread T1:
    #0 malloc <null>:3204112 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x48b3a)
    #1 swift_slowAlloc <null>:3204112 (libswiftCore.dylib:x86_64+0x344478)
    #2 File.__allocating_init(pathDeferringReading:) File.swift (swiftlint:x86_64+0x1000e71dc)
    #3 partial apply for File.__allocating_init(pathDeferringReading:) Configuration+LintableFiles.swift (swiftlint:x86_64+0x1002224fe)
    #4 thunk for @callee_owned (@owned String) -> (@owned File?, @error @owned Error) Configuration+LintableFiles.swift (swiftlint:x86_64+0x1002200c9)
    #5 partial apply for thunk for @callee_owned (@owned String) -> (@owned File?, @error @owned Error) Configuration+LintableFiles.swift (swiftlint:x86_64+0x10022024a)
    #6 Sequence.flatMap<A>(_:) <null>:3204112 (libswiftCore.dylib:x86_64+0x15fa87)
    #7 Configuration.getFiles(path:action:useSTDIN:quiet:useScriptInputFiles:) Configuration+CommandLine.swift:130 (swiftlint:x86_64+0x100897db0)
    #8 Configuration.visitLintableFiles(path:action:useSTDIN:quiet:useScriptInputFiles:cache:parallel:visitorBlock:) Configuration+CommandLine.swift:64 (swiftlint:x86_64+0x100895d94)
    #9 Configuration.visitLintableFiles(options:cache:visitorBlock:) Configuration+CommandLine.swift:147 (swiftlint:x86_64+0x1008a71cc)
    #10 LintCommand.run(_:) LintCommand.swift:47 (swiftlint:x86_64+0x10086781d)
    #11 protocol witness for CommandProtocol.run(_:) in conformance LintCommand LintCommand.swift (swiftlint:x86_64+0x1008744f6)
    #12 closure #1 in CommandWrapper.init<A>(_:) Command.swift:55 (swiftlint:x86_64+0x10003d263)
    #13 partial apply for closure #1 in CommandWrapper.init<A>(_:) Command.swift (swiftlint:x86_64+0x10004369b)
    #14 CommandRegistry.run(command:arguments:) Command.swift:109 (swiftlint:x86_64+0x10003f691)
    #15 CommandRegistry.main(arguments:defaultVerb:errorHandler:) Command.swift:174 (swiftlint:x86_64+0x100040497)
    #16 CommandRegistry.main(defaultVerb:errorHandler:) Command.swift:138 (swiftlint:x86_64+0x10003fd8e)
    #17 closure #1 in  main.swift:25 (swiftlint:x86_64+0x1008b4033)
    #18 thunk for @callee_owned () -> () QueuedPrint.swift (swiftlint:x86_64+0x1002778dc)
    #19 __tsan::invoke_and_release_block(void*) <null>:3204112 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x6619b)
    #20 _dispatch_client_callout <null>:3204112 (libdispatch.dylib:x86_64+0x1d4f)

  Mutex M1368 (0x7b180000c310) created at:
    #0 pthread_mutex_init <null>:3203968 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2b213)
    #1 -[NSLock init] <null>:3203968 (Foundation:x86_64+0x1d7d)
    #2 NSLock.__allocating_init() Clang+SourceKitten.swift (swiftlint:x86_64+0x1000b59d4)
    #3 Cache.init(_:) File+Cache.swift:60 (swiftlint:x86_64+0x100251cd7)
    #4 Cache.__allocating_init(_:) File+Cache.swift (swiftlint:x86_64+0x10024f30b)
    #5 globalinit_33_D93545007D2CCCB97554C3EFBF0F3773_func4 File+Cache.swift:31 (swiftlint:x86_64+0x100250a12)
    #6 dispatch_once <null>:3203968 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x66e04)
    #7 dispatch_once_f <null>:3203968 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x66ef6)
    #8 syntaxTokensByLinesCache.unsafeMutableAddressor File+Cache.swift:31 (swiftlint:x86_64+0x100250b89)
    #9 File.syntaxTokensByLines.getter File+Cache.swift:152 (swiftlint:x86_64+0x1002549a6)
    #10 ClosureSpacingRule.validBraces(in:) ClosureSpacingRule.swift:84 (swiftlint:x86_64+0x1003824c1)
    #11 ClosureSpacingRule.findViolations(file:) ClosureSpacingRule.swift:129 (swiftlint:x86_64+0x1003843b8)
    #12 ClosureSpacingRule.validate(file:) ClosureSpacingRule.swift:146 (swiftlint:x86_64+0x1003860d9)
    #13 protocol witness for Rule.validate(file:) in conformance ClosureSpacingRule ClosureSpacingRule.swift (swiftlint:x86_64+0x10038aea4)
    #14 Rule.lint(file:regions:benchmark:superfluousDisableCommandRule:) Linter.swift:71 (swiftlint:x86_64+0x1002bc733)
    #15 closure #2 in Linter.getStyleViolations(benchmark:) Linter.swift:138 (swiftlint:x86_64+0x1002cef1b)
    #16 partial apply for closure #2 in Linter.getStyleViolations(benchmark:) Linter.swift (swiftlint:x86_64+0x1002d785c)
    #17 thunk for @callee_owned (@in Rule) -> (@owned LintResult?) Linter.swift (swiftlint:x86_64+0x1002cf1ea)
    #18 partial apply for thunk for @callee_owned (@in Rule) -> (@owned LintResult?) Linter.swift (swiftlint:x86_64+0x1002d7949)
    #19 closure #1 in closure #1 in Array.parallelMap<A>(transform:) Array+SwiftLint.swift:66 (swiftlint:x86_64+0x100214779)
    #20 partial apply for closure #1 in closure #1 in Array.parallelMap<A>(transform:) Array+SwiftLint.swift (swiftlint:x86_64+0x100214f51)
    #21 thunk for @callee_owned (@unowned Int) -> () <null>:3203968 (libswiftDispatch.dylib:x86_64+0xb5a6)
    #22 _dispatch_client_callout2 <null>:3203968 (libdispatch.dylib:x86_64+0xc167)

  Thread T5 (tid=6333343, running) is a GCD worker thread

  Thread T6 (tid=6333344, running) is a GCD worker thread

  Thread T1 (tid=6333339, running) is a GCD worker thread

SUMMARY: ThreadSanitizer: data race File.swift:37 in File.lines.getter
==================
/Users/norio/github/SwiftLint/Package.swift:1:1: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
/Users/norio/github/SwiftLint/Package.swift:14:90: warning: Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)
/Users/norio/github/SwiftLint/Package.swift:22:34: warning: Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)
/Users/norio/github/SwiftLint/Package.swift:29:23: warning: Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)
/Users/norio/github/SwiftLint/Package.swift:38:28: warning: Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)
Done linting! Found 5 violations, 0 serious in 1 file.
ThreadSanitizer: reported 1 warnings

norio-nomura added a commit to jpsim/SourceKitten that referenced this issue Mar 14, 2018
@norio-nomura
Add exclusive control to File.contents and File.lines
20da01d 
Fix realm/SwiftLint#2089
@norio-nomura norio-nomura mentioned this issue Mar 14, 2018
Merged
@jpsim
Copy link
Collaborator

jpsim commented Mar 14, 2018

Nice find!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@norio-nomura @jpsim