fix: issue 2536

[forceddd]

This is a commit to fix issue 2536 and 2529.

When I was fixing 2529, I declared slotMetrics as a global variable, which caused all DayColumn instances to use the same instance of slotMetrics. This is also the reason why bug issue 2536 appears.

In this commit, I only modified the update timing of slotMetrics.Now both issues are resolved!

2024-03-25.15.36.56.mov

[cutterbl]

Loading your changes in Storybook, if I go to the onSelectSlot story and begin a selection, it immediately changes it to begin at the beginning of the day up to my selection point.

[forceddd]

Loading your changes in Storybook, if I go to the onSelectSlot story and begin a selection, it immediately changes it to begin at the beginning of the day up to my selection point.

This is an issue that exists in version 1.11.1 and is not caused by this commit.

[cutterbl]

@forceddd You are correct, but it was your previous PR that appears to have introduced this issue in the first place.

[forceddd]

@cutterbl This bug should have existed a long time ago. The issue 2290 seems to be the bug described.
I will try to fix it next week, if I successfully solve this issue, I will create another PR.

[cutterbl]

@forceddd Thanks for looking into this. An you are partly right. That issue you pointed out was for dragging up. Now it is also doing it even if dragging down (which was not an issue before your change).

[forceddd]

@cutterbl After each slotMetrics update, a new slots array will be created, but the _initialSlot object in DayColumn remains unchanged, so nextSlot becomes 0:00.
I modified nextSlot to handle this case. This video shows the performance after the modification.

2024-04-01.10.58.23.mov

[forceddd]

@cutterbl This is another related issue 2546.

[forceddd]

Is the margin-right here intentionally designed this way? Because when I'm selecting, there is no such spacing, but the rendered result has spacing. This makes me a little confused.

[nourbenamor201]

Is the margin-right here intentionally designed this way? Because when I'm selecting, there is no such spacing, but the rendered result has spacing. This makes me a little confused.

This is likely due to CSS styling, check for any CSS classes or inline styles that add margin or padding to the right.

[forceddd]

@cutterbl Would you please check this PR again? I submitted some new file changes.I think now this PR should be able to solve these related problems.

[cutterbl]

@forceddd Another defect (#2565 ) has come up around your changes. Not only is the onSelectSlot no longer returning a slotInfo.action of 'doubleClick', but the onDoubleClickEvent handler function no longer fires either.

[forceddd]

@forceddd Another defect (#2565 ) has come up around your changes. Not only is the onSelectSlot no longer returning a slotInfo.action of 'doubleClick', but the onDoubleClickEvent handler function no longer fires either.

@cutterbl Ok, today I will look at this issue and try to fix it.