[JUJU-1682] Utilities for subordinate units #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds is_subordinate, principal_unit and get_subordinates
Adds tests/integration/test_unit.py::test_subordinate_units
cderici
added
hint/2.9
SimonRichardson
approved these changes
Jun 9, 2023
|
/merge |
cderici
removed
the
area/forward-port
jujubot
added a commit
that referenced
this pull request
Jul 7, 2023
#897 ## What's Changed * [JUJU-1682] Utilities for subordinate units by @cderici in #879 * [JUJU-4018] Avoid upgrade resource in app refresh if upstream has same resource revision by @cderici in #884 * [JUJU-4112] Determining series for local bundle deploying local charm with manifest by @cderici in #896 * [JUJU-4188] Add 2.9.43 facades by @cderici in #895 * [JUJU-3998] Pass through local_refresh if refreshing with local charm & resources by @cderici in #894 * Revert arg name change in application.refresh by @cderici in #898 [JUJU-1682]: https://warthogs.atlassian.net/browse/JUJU-1682?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-4018]: https://warthogs.atlassian.net/browse/JUJU-4018?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-4112]: https://warthogs.atlassian.net/browse/JUJU-4112?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-4188]: https://warthogs.atlassian.net/browse/JUJU-4188?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-3998]: https://warthogs.atlassian.net/browse/JUJU-3998?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is in response to an LP bug, which is about getting the subordinate units using libjuju. The way that
zazawas doing it is incorrect, in that it uses theCharmfield in the subordinate units to get the charm_url. This is an internal field and shouldn't be used externally. Furthermore the naming of this field is somewhat misleading, as it's really theupgrading-fromfield that's being set only during an upgrade -to indicate the previous charm url prior to the upgrade- and it is to be deleted/unset right after the upgrade is done. This is why getting the charm-url from this field is not correct.This change adds some useful utilities (some fields and some methods) to interact with the subordinate units, in particular, we're adding:
ModelState.subordinate_unitsandmodel.subordinate_unitsApplication.subordinate_unitsUnit.is_subordinate,Unit.principal_unitandUnit.get_subordinates()QA Steps
This also adds the test
tests/integration/test_unit.py::test_subordinate_units, so the following should be working:Notes & Discussion
Marked to be forward-ported into the main branch.