Revert arg name change in application.refresh #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts a part of change in e2e60ae that changes the argument name from path -> local_charm_path to disambiguate the local charm path vs local resource path. However, this is a breaking change and requires users to run additional find/replace. So this will be done in the main branch rather than in 2.9.
jack-w-shaw
approved these changes
Jul 7, 2023
|
/merge |
jujubot
added a commit
that referenced
this pull request
Jul 7, 2023
#897 ## What's Changed * [JUJU-1682] Utilities for subordinate units by @cderici in #879 * [JUJU-4018] Avoid upgrade resource in app refresh if upstream has same resource revision by @cderici in #884 * [JUJU-4112] Determining series for local bundle deploying local charm with manifest by @cderici in #896 * [JUJU-4188] Add 2.9.43 facades by @cderici in #895 * [JUJU-3998] Pass through local_refresh if refreshing with local charm & resources by @cderici in #894 * Revert arg name change in application.refresh by @cderici in #898 [JUJU-1682]: https://warthogs.atlassian.net/browse/JUJU-1682?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-4018]: https://warthogs.atlassian.net/browse/JUJU-4018?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-4112]: https://warthogs.atlassian.net/browse/JUJU-4112?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-4188]: https://warthogs.atlassian.net/browse/JUJU-4188?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-3998]: https://warthogs.atlassian.net/browse/JUJU-3998?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per discussion in e2e60ae#commitcomment-120947922, this reverts a part of change in e2e60ae that renames an argument name from
path->local_charm_pathto disambiguate the local charm path vs local resource path. However, this is a breaking change in 2.9 and requires users to run additional find/replace in their code. So this improvement will be done in a minor release on the main branch rather than breaking 2.9.QA Steps
This is just a rename and no functionality has changed, so no QA is needed (linter is checking for typos).