[JUJU-4110] charm_name on Application object
#901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cderici
added
hint/2.9
jack-w-shaw
approved these changes
Jul 12, 2023
|
/merge |
cderici
removed
the
area/forward-port
jujubot
added a commit
that referenced
this pull request
Jul 20, 2023
#910 #### Description This brings forward from `2.9` the following PRs: #901, #905, and #896 into `3.x` (the main branch). #### QA Steps There were a couple of conflicts that needed to be fixed, so QA will be necessary, make sure the following tests are passing: ``` tox -e integration -- tests/integration/test_application.py::test_app_charm_name ``` ``` tox -e py3 -- -m wait_for_idle ``` ``` tox -e integration -- -m wait_for_idle ``` ```sh tox -e integration -- tests/integration/test_model.py::test_deploy_bundle_local_charm_series_manifest ```
jujubot
added a commit
that referenced
this pull request
Jul 20, 2023
#919 ## What's Changed * [JUJU-4110] `charm_name` on Application object by @cderici in #901 * [JUJU-4204] Model.name on 2.9 by @cderici in #902 * [JUJU-4231] wait_for_idle to consider app status by @cderici in #905 * Stabilize sphinx doc builds for `2.9` track by @cderici in #911 * Add pytest.ini to register custom pytest marks by @cderici in #912 * [JUJU-4291] Removing Upper Constraint by @markbeierl in #916 [JUJU-4110]: https://warthogs.atlassian.net/browse/JUJU-4110?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-4204]: https://warthogs.atlassian.net/browse/JUJU-4204?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-4231]: https://warthogs.atlassian.net/browse/JUJU-4231?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-4291]: https://warthogs.atlassian.net/browse/JUJU-4291?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
charm_nameproperty inApplicationobject, which saves people from going through the status and stripping things from the charm URL, just to get the name of the charm.Fixes #888
The issue in there was that the
FullStatusactually returns the charm URL as thecharmfield in[] ApplicationStatusfield, but the client is aliasing it before printing so you see only the charm name in thejuju status --format yamlhttps://github.com/juju/juju/blob/87d8ddc9de5219b3a1d854e14ee4c90a7d781d25/cmd/juju/status/formatter.go#L267
QA Steps