[JUJU-4291] Removing Upper Constraint #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason to believe that future versions of PyYAML will not be compatible with this package, so we are removing this is an upper bound Signed-off-by: Mark Beierl <[email protected]>
|
Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch. |
1 similar comment
|
Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch. |
ghislainbourgeois
approved these changes
Jul 19, 2023
cderici
approved these changes
Jul 19, 2023
|
/merge |
1 similar comment
|
/merge |
cderici
added
hint/2.9
|
/build |
1 similar comment
|
/build |
|
/merge |
cderici
changed the title
cderici
added a commit
to cderici/python-libjuju
that referenced
this pull request
Jul 20, 2023
Forward port from juju#916
This was referenced Jul 20, 2023
jujubot
added a commit
that referenced
this pull request
Jul 20, 2023
#919 ## What's Changed * [JUJU-4110] `charm_name` on Application object by @cderici in #901 * [JUJU-4204] Model.name on 2.9 by @cderici in #902 * [JUJU-4231] wait_for_idle to consider app status by @cderici in #905 * Stabilize sphinx doc builds for `2.9` track by @cderici in #911 * Add pytest.ini to register custom pytest marks by @cderici in #912 * [JUJU-4291] Removing Upper Constraint by @markbeierl in #916 [JUJU-4110]: https://warthogs.atlassian.net/browse/JUJU-4110?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-4204]: https://warthogs.atlassian.net/browse/JUJU-4204?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-4231]: https://warthogs.atlassian.net/browse/JUJU-4231?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-4291]: https://warthogs.atlassian.net/browse/JUJU-4291?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
neoaggelos
added a commit
to neoaggelos/python-libjuju
that referenced
this pull request
Jul 24, 2023
Forward port from juju#916
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason to believe that future versions of PyYAML will not be compatible with this package, so we are removing this is an upper bound
Description
Python libjuju cannot be installed with the latest version of PyYAML (6.0.1), which fixes a breaking change caused by an update to CPython.
Fixes: #913
By removing the upper constraint on PyYAML, we can allow for future updates to this package to work with ours.
QA Steps
Attempt to install both PyYAML 6.0.1 and Python Juju at the same time: