Resolve min as the earliest compatible Julia version (compatible with the user's project)
#202
Conversation
|
Did some basic local testing but need to add real tests before this is ready for review |
|
Does this work for all |
| // Use the highest available version that matches versionInput | ||
| let version = semver.maxSatisfying(availableReleases, versionInput, {includePrerelease}) | ||
| if (version == null) { | ||
| if (!version) { |
There was a problem hiding this comment.
What's the difference between (!version) (this PR) and if (version == null) (on master)?
There was a problem hiding this comment.
So the issue with the original code is that null == undefined is also true so the original statement is kind of misleading. I switched things to be based on "truthy"-ness so now we thrown an exception on any value that is coerced into a false such as null, undefined, or "".
|
@omus Looks like there are some merge conflicts. |
DilumAluthge
changed the title
min as the earliest compatible Julia version (compatible with the user's project)
DilumAluthge
changed the title
min as the earliest compatible Julia version (compatible with the user's project)MIN as the earliest compatible Julia version (compatible with the user's project)
There was a problem hiding this comment.
With #234 merged I think it makes sense to make this lowercase min
Seems reasonable to me. |
DilumAluthge
dismissed
their stale review
stale - MIN needs to be changed to min
|
@omus do you agree with that change? I could take this PR over? |
omus
changed the title
MIN as the earliest compatible Julia version (compatible with the user's project)min as the earliest compatible Julia version (compatible with the user's project)
This comment was marked as resolved.
This comment was marked as resolved.
|
Should be fixed. Sorry. I forgot to update the tag to the tip of the release branch after missing adding that index file. |
Introduces a special version
"MIN""min" which when passed in as theversionallows the user to test against the earliest version of Julia compatible with their project. In order to determine this version the project file is read.If we want we can choose another name for this special version but I would like to keep the name short as this usually appears in the CI check name which can already be quite long.Update: We've decided on
"min"as the special version name