Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve
min
as the earliest compatible Julia version (compatible with the user's project) #202Resolve
min
as the earliest compatible Julia version (compatible with the user's project) #202Changes from 17 commits
f6c0c51
4467bdb
a01d66b
ba08cda
c551d5c
319c0e6
bc76ff4
0c43806
20471b9
ccc4e23
03c056a
b69821d
e371afc
304b120
5dfcf28
b8106f2
10a9b2f
02aa933
d897c08
ac7c4d5
70ba35f
266d809
0718bbf
f13a394
8a8dfd5
df5b495
e5a91a7
1170aba
1259c4f
ed73f04
ecaeb80
b38942a
1665281
34392a0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between
(!version)
(this PR) andif (version == null)
(on master)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the issue with the original code is that
null == undefined
is also true so the original statement is kind of misleading. I switched things to be based on "truthy"-ness so now we thrown an exception on any value that is coerced into afalse
such asnull
,undefined
, or""
.