🐛 Do not fail on citation.js (#1076)

See #1072
jupyter-book · Apr 8, 2024 · 8ca2c51 · 8ca2c51
1 parent 770c15f
commit 8ca2c51
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 5 deletions.
diff --git a/.changeset/curvy-ligers-clap.md b/.changeset/curvy-ligers-clap.md
@@ -0,0 +1,5 @@
+---
+"myst-cli": patch
+---
+
+Do not error on invalid citation bibtex
diff --git a/packages/myst-cli/src/transforms/dois.ts b/packages/myst-cli/src/transforms/dois.ts
@@ -5,7 +5,7 @@ import { getCitations } from 'citation-js-utils';
 import { doi } from 'doi-utils';
 import type { Link } from 'myst-spec';
 import type { GenericNode, GenericParent } from 'myst-common';
-import { fileWarn, toText, RuleId, plural } from 'myst-common';
+import { fileWarn, toText, RuleId, plural, fileError } from 'myst-common';
 import { selectAll } from 'unist-util-select';
 import { computeHash, tic } from 'myst-cli-utils';
 import type { Cite } from 'myst-spec-ext';
@@ -118,10 +118,23 @@ export async function getCitation(
     });
     return null;
   }
-  const renderer = await getCitations(bibtex);
-  const id = Object.keys(renderer)[0];
-  const render = renderer[id];
-  return { id, render };
+  try {
+    const renderer = await getCitations(bibtex);
+    const id = Object.keys(renderer)[0];
+    const render = renderer[id];
+    return { id, render };
+  } catch (error) {
+    fileError(
+      vfile,
+      `BibTeX from doi.org was malformed, please edit and add to your local references`,
+      {
+        node,
+        ruleId: RuleId.doiLinkValid,
+        note: `\nBibTeX from ${doiString}:\n\n${bibtex}\n`,
+      },
+    );
+    return null;
+  }
 }
 
 /**