Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fatal error when apparently invalid doi is encountered #1072

Closed
stevejpurves opened this issue Apr 8, 2024 · 0 comments · Fixed by #1073
Closed

Fatal error when apparently invalid doi is encountered #1072

stevejpurves opened this issue Apr 8, 2024 · 0 comments · Fixed by #1073
Assignees
@agoose77
Labels
bug Something isn't working

Comments

@stevejpurves
Copy link
Contributor

Description

The following markdown:

# DOI Errors

The following DOI causes the myst build to fail, even though it is a valid doi.

https://doi.org/10.2903/j.efsa.2019.5779

...causes the myst build to fail.

Proposed solution

(1) It is a valid DOI so there should be no problem parsing it (2) if it was an invalid doi then parsing should fail with a warning.

Additional notes

myst -v
v1.1.51
@stevejpurves stevejpurves added the bug Something isn't working label Apr 8, 2024
@agoose77 agoose77 self-assigned this Apr 8, 2024
@agoose77 agoose77 mentioned this issue Apr 8, 2024
Merged
rowanc1 added a commit that referenced this issue Apr 8, 2024
@rowanc1
🐛 Do not fail on citation.js
8794643 
See #1072
@rowanc1 rowanc1 mentioned this issue Apr 8, 2024
Merged
rowanc1 added a commit that referenced this issue Apr 8, 2024
@rowanc1
🐛 Do not fail on citation.js (#1076)
8ca2c51 
See #1072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agoose77 agoose77

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Request DOI metadata as CSL-JSON after BibTeX jupyter-book/mystmd
2 participants
@agoose77 @stevejpurves