Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Unpin jedi #502

Merged
merged 5 commits into from
May 29, 2021
Merged

[wip] Unpin jedi #502

merged 5 commits into from
May 29, 2021

Conversation

bollwyvl
Copy link
Collaborator

@bollwyvl bollwyvl commented Feb 2, 2021

ipython 7.20 just landed (as did seleniumlibrary 5), let's see if everything's cool!

Binder

References

Code changes

n/a

User-facing changes

  • removes jupyter-offlinenotebook from binder so it doesn't pop the build warning

Backwards-incompatible changes

n/a

Chores

  • linted
  • tested
  • documented
  • changelog entry

@bollwyvl
Copy link
Collaborator Author

bollwyvl commented Feb 2, 2021

Graah, as with jupyter/jupyter_client#615, we want to unpin jed, but only on py3.7+...

binder/postBuild Outdated Show resolved Hide resolved
@bollwyvl
Copy link
Collaborator Author

bollwyvl commented Feb 18, 2021 via email

@krassowski krassowski closed this Mar 19, 2021
@krassowski krassowski reopened this Mar 19, 2021
@krassowski
Copy link
Member

krassowski commented Mar 19, 2021

So we have a pip check failing. Unpinning jedi solves part of the issue (with pyls), but there is still:

autopep8 1.5.6 has requirement pycodestyle>=2.7.0, but you have pycodestyle 2.6.0.

Edit: after pinning pycodestyle and flake8 to modern versions:

Problem: package flake8-3.9.0-pyhd8ed1ab_0 requires pyflakes >=2.3.0,<2.4.0, but none of the providers can be installed

so now it seems pyflakes has an issue on conda...

@krassowski
Copy link
Member

Though pyflakes 2.3 seems to be on conda-forge: https://github.com/conda-forge/pyflakes-feedstock ...

@bollwyvl
Copy link
Collaborator Author

So... we're not getting very helpful feedback, but I think what we're probably seeing is getting a partial solved for a pyls that is so old it (wrongly) doesn't have a jedi pin. On 3.6, this is pulling in the three year old 0.11.1:

python-language-server    0.11.1                   py36_0    conda-forge

So I don't think we can really unpin jedi until python-ls has a release...

@krassowski
Copy link
Member

Merging should solve #598.

@krassowski krassowski merged commit 9bfc541 into jupyter-lsp:master May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants