Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pip install in git checkout #319

Merged
merged 1 commit into from
May 18, 2022
Merged

Fix pip install in git checkout #319

merged 1 commit into from
May 18, 2022

Conversation

blink1073
Copy link
Contributor

  • Check for pyproject.toml
  • Install both dev and test extras (will warn if either do not exist).

@blink1073 blink1073 added the enhancement New feature or request label May 18, 2022
@blink1073 blink1073 mentioned this pull request May 18, 2022
Merged
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022 •
edited
Loading

Codecov Report

Merging #319 (d0b6a18) into main (e4a707f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #319   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files          19       19           
  Lines        2555     2555           
  Branches      336      336           
=======================================
  Hits         2143     2143           
  Misses        296      296           
  Partials      116      116
Impacted Files Coverage Δ
jupyter_releaser/lib.py 82.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4a707f...d0b6a18. Read the comment docs.

@blink1073 blink1073 merged commit ede808f into main May 18, 2022
@blink1073 blink1073 deleted the blink1073-patch-1 branch May 18, 2022 10:41
@jtpio jtpio mentioned this pull request May 18, 2022
Merged
5 tasks
jtpio
jtpio reviewed May 19, 2022
View reviewed changes
jupyter_releaser/lib.py
if util.SETUP_PY.exists():
util.run('pip install -q -e ".[test]"')
# install python package in editable mode with dev and test deps
if util.PYPROJECT.exists():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this seems to be causing issues with projects using a top-level pyproject.toml to manage configuration for Python monorepos (isort, tbump), without the top-level being installable.

Noticed in jupyterlite/jupyterlite#644 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there could be a new releaser configurable option to skip this installation step.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or the installation step moved to another step, so it can be skip-ed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoisted to #321

@jtpio jtpio mentioned this pull request May 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blink1073 @codecov-commenter @jtpio