Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pip install in git checkout #319

Merged
merged 1 commit into from
May 18, 2022
Merged

Fix pip install in git checkout #319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions jupyter_releaser/lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,9 +597,9 @@ def prep_git(ref, branch, repo, auth, username, url):
util.run(f"git switch -c {branch}")

# Install the package
# install python package in editable mode with test deps
if util.SETUP_PY.exists():
util.run('pip install -q -e ".[test]"')
# install python package in editable mode with dev and test deps
if util.PYPROJECT.exists():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this seems to be causing issues with projects using a top-level pyproject.toml to manage configuration for Python monorepos (isort, tbump), without the top-level being installable.

Noticed in jupyterlite/jupyterlite#644 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there could be a new releaser configurable option to skip this installation step.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or the installation step moved to another step, so it can be skip-ed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoisted to #321

util.run('pip install -q -e ".[dev,test]"')

# prefer yarn if yarn lock exists
elif util.YARN_LOCK.exists():
Expand Down