use setuptools find_packages, exclude tests, docs and examples from dist #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
oh, and we may need to add a temporary pin for |
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
==========================================
+ Coverage 69.29% 69.30% +0.01%
==========================================
Files 56 56
Lines 6135 6135
Branches 804 804
==========================================
+ Hits 4251 4252 +1
Misses 1616 1616
+ Partials 268 267 -1
Continue to review full report at Codecov.
|
|
Cool (i guess) looks like jedi's not breaking anything... |
kevin-bates
approved these changes
Jan 3, 2021
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
* update locks to jupyterlab 3.4.1 * print pip version
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
use setuptools find_packages, exclude tests, docs and examples from dist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
find_packagesfromsetupbase.pysetuptools.find_packagestoexcludethings that might be python-module-likeIn
site-packages/,tests/,docs/, etc. are dumping grounds of all the packages that either don't use this flag. In this state, it's not even worth distributing them, as there's basically zero chance they'll work. Putting them in-tree, on the other hand, is very nice, as downstreams can ensure that their packages work, which helps catch issues sooner, but that's for another day...