-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make unit tests backwards compatible without pending kernels #669
Conversation
Codecov Report
@@ Coverage Diff @@
## main #669 +/- ##
==========================================
+ Coverage 77.79% 77.88% +0.09%
==========================================
Files 110 110
Lines 10409 10456 +47
Branches 1399 1402 +3
==========================================
+ Hits 8098 8144 +46
+ Misses 1922 1920 -2
- Partials 389 392 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We need to remove this config and instead add the argument to the test invocations in the workflows, since we no longer support doctest in the link check job |
@blink1073, thanks! done 👍 |
18f278f
to
7819295
Compare
pyproject.toml
Outdated
@@ -9,7 +9,6 @@ factory = "jupyter_packaging.npm_builder" | |||
ignore = ["tbump.toml", ".*", "*.yml", "package-lock.json", "bootstrap*", "conftest.py"] | |||
|
|||
[tool.pytest.ini_options] | |||
addopts = "--doctest-modules" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can revert the doctest-related changes, we fixed this in jupyter-server/jupyter_releaser#246
We picked up a couple merge conflicts from #673 |
a08f594
to
05e3532
Compare
Fixes #666.