Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(temporarily) skip pending kernels unit tests on Windows CI #673

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Jan 21, 2022

Unit tests that test pending kernels are failing on our Windows CI.

It will take me some time to investigate these failures, so I proposed temporarily skipping these tests in #672. We will keep that issue open to track updates in the future.

I've also changed the pytest logic a bit to be more explicit when testing MappingKernelManager vs. AsyncMappingKernelManager and use_pending_kernels.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2022

Codecov Report

Merging #673 (18f5ed3) into main (d201529) will decrease coverage by 0.90%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
- Coverage   77.76%   76.86%   -0.91%     
==========================================
  Files         110      110              
  Lines       10415    10070     -345     
  Branches     1403     1239     -164     
==========================================
- Hits         8099     7740     -359     
- Misses       1926     1936      +10     
- Partials      390      394       +4     
Impacted Files Coverage Δ
jupyter_server/tests/services/sessions/test_api.py 96.55% <85.71%> (-0.05%) ⬇️
jupyter_server/tests/services/kernels/test_api.py 94.81% <87.50%> (-0.12%) ⬇️
jupyter_server/tests/services/kernels/test_cull.py 100.00% <100.00%> (ø)
jupyter_server/extension/handler.py 52.00% <0.00%> (-6.63%) ⬇️
...r/tests/unix_sockets/test_serverapp_integration.py 17.07% <0.00%> (-4.77%) ⬇️
jupyter_server/services/shutdown.py 66.66% <0.00%> (-3.34%) ⬇️
jupyter_server/gateway/gateway_client.py 72.89% <0.00%> (-3.30%) ⬇️
jupyter_server/files/handlers.py 26.08% <0.00%> (-3.08%) ⬇️
jupyter_server/terminal/api_handlers.py 85.00% <0.00%> (-2.50%) ⬇️
jupyter_server/base/handlers.py 63.10% <0.00%> (-2.42%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d201529...18f5ed3. Read the comment docs.

@blink1073 blink1073 merged commit d3bc6bf into jupyter-server:main Jan 24, 2022
@Zsailer Zsailer deleted the pending-kernels-windows branch January 16, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants