-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding reset_kc to setup_kernel #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a decent idea, thanks for opening a PR. I would like to have a test confirming the new keyword works as expected though.
I will add a test soon, I edited this directly on GitHub 🙈 Let me know what you prefer in terms of name/functionality. I can also clean up If you want to maintain the current convention I guess the default should be |
@davidbrochart what do you think about changing |
Yes it is more coherent to change it to |
I cleaned changed Cleaned up a bit I think this should make it more coherent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Matching what async_setup_kernel does.