Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding reset_kc to setup_kernel #53

Merged
merged 6 commits into from
May 20, 2020
Merged

Adding reset_kc to setup_kernel #53

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
75dc5be
Adding reset_kc to setup_kernel
danielfrg May 14, 2020
a1369f3
flake8
danielfrg May 14, 2020
4494b78
Clean reset_kc and cleanup_kc
danielfrg May 19, 2020
9aa92d8
Merge branch 'master' into patch-1
danielfrg May 19, 2020
80fe510
Clean arguments
danielfrg May 19, 2020
7cfe9f4
Fix arg
danielfrg May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion nbclient/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,8 @@ def setup_kernel(self, **kwargs):
When control returns from the yield it stops the client's zmq channels, and shuts
down the kernel.
"""
reset_kc = kwargs.pop('reset_kc', False)
danielfrg marked this conversation as resolved.
Show resolved Hide resolved

# Can't use run_until_complete on an asynccontextmanager function :(
if self.km is None:
self.start_kernel_manager()
Expand All @@ -420,7 +422,8 @@ def setup_kernel(self, **kwargs):
try:
yield
finally:
self._cleanup_kernel()
if reset_kc:
self._cleanup_kernel()

@asynccontextmanager
async def async_setup_kernel(self, **kwargs):
Expand Down