Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer messages when websocket connection is interrupted #2871

Merged
merged 5 commits into from
Oct 6, 2017
Merged

buffer messages when websocket connection is interrupted #2871

merged 5 commits into from
Oct 6, 2017

Commits on Sep 28, 2017

  1. provide some top level comments

    @rgbkrk
    rgbkrk committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    569bb25 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2017

  1. implement buffering of messages on last dropped connection 

    - buffer is per-kernel
- session_key is stored because only a single session can resume the buffer and we can't be sure
- on any new connection to a kernel, buffer is flushed.
  If session_key matches, it is replayed.
  Otherwise, it is discarded.
- buffer is an unbounded list for now
    @minrk
    minrk committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    8f8363a View commit details
    Browse the repository at this point in the history

  2. restore actual zmq channels when resuming connection 

    rather than establishing new connections

fixes failure to resume shell channel
    @minrk
    minrk committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    38224fb View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2017

  1. hookup restart callbacks in open 

    instead of in `create_stream`, which is not called on reconnect
    @minrk
    minrk committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    68602fa View commit details
    Browse the repository at this point in the history

  2. improve handling of restored connections in js 

    - dismiss 'connection lost' dialog on reconnect
- set busy status on reconnect (if not busy, idle will come soon after via kernel_ready)
    @minrk
    minrk committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    db4ca5e View commit details
    Browse the repository at this point in the history