Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unknown job state: Improvements of #179 to make tests pass #187

Merged
merged 14 commits into from
Dec 2, 2020
Merged

unknown job state: Improvements of #179 to make tests pass #187

merged 14 commits into from
Dec 2, 2020

Commits on Jun 23, 2020

  1. Add logic to handle cases where the rm is not answering

    @cmd-ntrf
    cmd-ntrf committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    b107e47 View commit details
    Browse the repository at this point in the history

  2. Extend slurm unknown regex

    @cmd-ntrf
    cmd-ntrf committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    6fbb5b6 View commit details
    Browse the repository at this point in the history

  3. Add check to state_isunknown in stop

    @cmd-ntrf
    cmd-ntrf committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    dd5ac3f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Rename read_job_state as query_job_status 

    Avoid confusion with the *_state methods
    @cmd-ntrf
    cmd-ntrf committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    afa666b View commit details
    Browse the repository at this point in the history

  2. Replace poll by query_job_status 

    Calling poll meant we would be running state_isrunning and
state_ispending twice.
    @cmd-ntrf
    cmd-ntrf committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    ff9ab2a View commit details
    Browse the repository at this point in the history

  3. Define JobStatus and make query_job_status return a JobStatus

    @cmd-ntrf
    cmd-ntrf committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    68be363 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Rename NOTQUEUED as NOTFOUND

    @cmd-ntrf
    cmd-ntrf committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    8aa71b4 View commit details
    Browse the repository at this point in the history

  2. Add docstring to query_job_status

    @cmd-ntrf
    cmd-ntrf committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    fc522b6 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. batchspawner/batchspawner: Fixups of jupyterhub#179

    @rkdarst
    rkdarst committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    e6c0a3e View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. batchspawner/tests/test_spawners: Mark slow tests 

    - The slow test can now be skipped with `-k-slow` .
    @rkdarst
    rkdarst committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    7dda947 View commit details
    Browse the repository at this point in the history

  2. batchspawner/batchspawner: .clear_state() if spawning fails 

    - The query_job_state change meant we don't call .poll() within the
  .start() method anymore.  .poll() would .clear_state() if the job
  was not found.
- So old state was: .clear_state() was called if the spawn failed.
- Add in .clear_state() explicitely when spawning fails.
- I think that if there are exceptions in unexpected places, then
  state will still not be cleared.  It's no worse than before, so we
  can leave it is-is for now.
    @rkdarst
    rkdarst committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    c81298d View commit details
    Browse the repository at this point in the history

  3. tests: Adjust tests for query_job_state 

    - Semantics of the status changes slightly, adjust to the new form
- Add split the starting test:
  - job status query fails when it is first submitted
  - job status query fails after it has started
    @rkdarst
    rkdarst committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    944771d View commit details
    Browse the repository at this point in the history

  4. tests: Add a test for the unknown status

    @rkdarst
    rkdarst committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    8bc3226 View commit details
    Browse the repository at this point in the history

  5. tests: Add slurm test of unknown job state

    @rkdarst
    rkdarst committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    87c5eba View commit details
    Browse the repository at this point in the history