unknown job state: Improvements of #179 to make tests pass #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid confusion with the *_state methods
Calling poll meant we would be running state_isrunning and state_ispending twice.
- The slow test can now be skipped with `-k-slow` .
- The query_job_state change meant we don't call .poll() within the .start() method anymore. .poll() would .clear_state() if the job was not found. - So old state was: .clear_state() was called if the spawn failed. - Add in .clear_state() explicitely when spawning fails. - I think that if there are exceptions in unexpected places, then state will still not be cleared. It's no worse than before, so we can leave it is-is for now.
- Semantics of the status changes slightly, adjust to the new form - Add split the starting test: - job status query fails when it is first submitted - job status query fails after it has started
|
Thanks for putting so much effort into this. |
|
Discussed in monthly meeting, plan to merge now and create RC feature release after some testing. |
This was referenced Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if I should edit that one.
rkdarst@c81298d
(which I'd recommend that people review if they want to review anything)
exact spawning process, but I think I got it and it matches the
behavior expected by JupyterHub. But I encourage anyone with deeper
wisdom to take a look.