batchspawner/batchspawner: Fix exception handling in run_command. #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exception handling in run_command had several issues which this commit fixes: - Don't use undefined variable. - communicate() may block forever if process already closed the pipes. - exceptions during exception handling were not handled.
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
This LGTM and is a obvious bugfix! Thank you @olifre ❤️ 🎉 Thank you for your clear PR summary, it provided very relevant help for me to review this! |
|
@consideRatio Many thanks for merging and for the positive feedback, this really makes contributing a delight 😄 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception handling in run_command had several issues
which this commit fixes:
closed the pipes.