You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since our PRs are so stagnent, I made a summary of them below to hopefully help maintainers decide what to do. Or maybe encourage more people to take a look.
Six should be used right away, some are old. At least three can be closed.
Fail hard on first error in batch script #177 (job script set -e) - makes sense, someone either needs to do it and accept some people's use cases will change, or accept that we can never change it. Needs changelog entry.
add 'gres' option to SlurmSpawner #170 (slurm --gres option) Should be accepted if we want more options, instead of the generic req_options. Needs changelog entry, I already added one but it is out of date since the release.
Initial support for OAR batch scheduler #136 (OAR) I would probably reject this, since the OAR scheduler seems sort of insecure, and make it some sort of community recipe. We can help people do it, but shouldn't make it easy to do insecure things out of the box.
Environment handling refactoring. #119 (environment refactoring) This was a draft test of mine, no point to work on it until we have a way to accept new ideas.
@rkdarst I merged some PRs (#195, #196, #198, #199) and updated this table to reflect how that influenced the list above. I also opened #208 to catch up with various practices across the JupyterHub org that feels good to be somewhat systematic about.
Thanks for doing the work to overview PRs in this repo, while I have no experience with the actual code base itself feel free to ping me for help.
Since our PRs are so stagnent, I made a summary of them below to hopefully help maintainers decide what to do. Or maybe encourage more people to take a look.
Six should be used right away, some are old. At least three can be closed.
The text was updated successfully, but these errors were encountered: