[WIP, demo only] command to terminate jobs before killing them #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkdarst
force-pushed
the
interrupt_before_cancel
branch
2 times, most recently
from
3706c99
to
9cc5c22
Compare
rkdarst
force-pushed
the
interrupt_before_cancel
branch
from
9cc5c22
to
b881918
Compare
rkdarst
force-pushed
the
interrupt_before_cancel
branch
from
b881918
to
85dd3d4
Compare
- Add ability to sent SIGTER before the cancel command is called. This might give the notebook server a chance to clean up first. - Implemented for slurm only as a demo, but it is not actually needed for slurm. - Do not merge, example only!
rkdarst
force-pushed
the
interrupt_before_cancel
branch
from
85dd3d4
to
cd7d77c
Compare
|
Given this is 6y old, I'm going to close this to clean things out. Hope that's ok @rkdarst! Please re-open if you disagree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept of adding a new command
batch_term_cmdwhich will send SIGTERM to jobs beforebatch_cancel_commandsends SIGKILL. However, most of the batch systems implement something like this natively, so hopefully this does not need to be implemented most of the time. There is a demo for slurm, that isn't needed and should be rebased out before this is used.If it was needed, it would solve #50 in a generalized manner.
The support might be useful for other spawners, so I am showing the code, but shouldn't be merged until it has a purpose. Also it must be updated for at least #72 and #73.
This might give the notebook server a chance to clean up first.
for slurm.