Add options to install source, docs, and examples #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddalcino
commented
Mar 19, 2023
Comment on lines
248
to
250
| private static getBoolInput(name: string): boolean { | ||
| return core.getInput(name).toLowerCase() === "true"; | ||
| } |
There was a problem hiding this comment.
Does anyone know where this Inputs.getBoolInput function came from? It looks like a duplicate of getBooleanInput(name: string, options?: InputOptions): boolean from @actions/core (see docs) to me. Should we be using that instead?
There was a problem hiding this comment.
This action is kinda old now, so it wouldn't surprise me if there is a new method now. Feel free to make a PR and fix that, but no problem for now.
ddalcino
commented
Mar 19, 2023
|
If you fix the merge conflict I will merge it. Sorry for the delay, life at university is busy as always. |
If a user wants to install source, docs, or examples, without installing Qt binaries, then that user would have to turn on `tools-only`. That option does not make semantic sense for these use cases, since the user is not installing tools alone, and may not be installing tools at all. This change allows a user to turn off installation of Qt binaries using an option that makes sense semantically.
This is meant to DRY-up some repetitive code, for readability and maintainability benefits.
ddalcino
force-pushed
the
topic/add-src-doc-examples
branch
from
474fa82
to
2a2a30b
Compare
@jurplel all merge conflicts are now resolved. |
jurplel
added a commit
that referenced
this pull request
Aug 4, 2023
Add options to install source, docs, and examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #87
The code for installing source is very similar to the code that installs examples and docs, so I went ahead and implemented all of them.
This PR probably includes more refactoring than it should, but I was careful to keep all the refactors in their own commits, in case you want to move them to a separate PR. This PR would be too tedious for me to write without using these refactors, so they're included anyway.
Please see the changes to the README.md for a discussion of all the new features added here.