[v4] Install desktop Qt when required to by Qt 6.2+ mobile and WASM #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--autodesktop` flag is not available in `aqtinstall < 3.0.0`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #181. This will allow both mobile and WASM builds to succeed, when using Qt 6.2+. These new versions of Qt require a parallel installation of the desktop version of Qt, installed alongside the mobile or WASM versions.
As a side effect, this PR also fixes a logic bug in the way the
archinput is set by default. When the user does not select an arch on Windows, and the target is set toandroid, the action selects a Windows desktop arch instead of an android arch. The change that fixes this issue is in its own commit: 8cd6038This PR makes breaking changes, discussed in the new
README_upgrade_guide.mdfile. For that reason, this change should not be merged into v3 of this action.This PR uses #179 as a starting point. I needed to use an example project meant for mobile devices in order to test Qt for Android properly, and there are some good ones in the
Examplesdirectory that you can install usingaqt install-example. It was easier to accomplish that using the changes in #179 than in some other way.I have added tests for android in their own workflow. This will result in some code duplication, but IMHO it's a lot easier to read and to reason about the tests this way than it would have been if I had added the tests to the existing
test.ymlworkflow.