-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the etcd retention to delete orphaned snapshots based on the date #8177
Merged
vitorsavian
merged 12 commits into
k3s-io:master
from
vitorsavian:etcd-snapshots-retention
Aug 14, 2023
Merged
Fixed the etcd retention to delete orphaned snapshots based on the date #8177
vitorsavian
merged 12 commits into
k3s-io:master
from
vitorsavian:etcd-snapshots-retention
Aug 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitor <[email protected]>
Signed-off-by: Vitor <[email protected]>
Signed-off-by: Vitor <[email protected]>
Signed-off-by: Vitor <[email protected]>
Signed-off-by: Vitor <[email protected]>
Signed-off-by: Vitor <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #8177 +/- ##
==========================================
+ Coverage 44.10% 50.78% +6.68%
==========================================
Files 144 144
Lines 14614 14620 +6
==========================================
+ Hits 6445 7425 +980
+ Misses 7111 6016 -1095
- Partials 1058 1179 +121
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Vitor <[email protected]>
dereknola
approved these changes
Aug 14, 2023
osodracnai
approved these changes
Aug 14, 2023
briandowns
reviewed
Aug 14, 2023
Signed-off-by: Vitor <[email protected]>
Signed-off-by: Vitor <[email protected]>
Signed-off-by: Vitor <[email protected]>
This was referenced Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Delete the oldest snapshot files inside the node and s3 if the snapshot count is greater than the retention, regardless of the node name.
The delete will occur based on the the date in the name of the file.
Types of Changes
Verification
Need to create a cluster with etcd snapshots enabled and s3
Then you can see in the /var/lib/rancher/k3s/server/db/snapshots that will maintain the retention
If you are using AWS, you can just reboot the machine to have another name, and just restarted the cluster, it will still delete the snapshot inside
/var/lib/rancher/server/db/snapshots
and maintain the retentionTesting
Linked Issues
User-Facing Change
Further Comments