[Release 1.26] Fixed the etcd retention to delete orphaned snapshots based on the date

[vitorsavian]

Proposed Changes

• Delete the oldest snapshot files inside the node and s3 if the snapshot count is greater than the retention, regardless of the node name.

• The delete will occur based on the the date in the name of the file.

Types of Changes

• backports from Fixed the etcd retention to delete orphaned snapshots based on the date #8177

Verification

Need to create a cluster with etcd snapshots enabled and s3

k3s server --cluster-init --etcd-snapshot-schedule-cron "*/1 * * * *" --etcd-snapshot-retention 2 --etcd-s3 --etcd-s3-access-key --etcd-s3-secret-key --etcd-s3-bucket

Then you can see in the /var/lib/rancher/k3s/server/db/snapshots that will maintain the retention

ls /var/lib/rancher/server/db/snapshots

If you are using AWS, you can just reboot the machine to have another name, and just restarted the cluster, it will still delete the snapshot inside /var/lib/rancher/server/db/snapshots and maintain the retention

Testing

Linked Issues

• [Backport release-1.26] etcd snapshot cleanup fails if node name changes rancher/rke2#4536

User-Facing Change

NONE

Further Comments

• This fix was found in the Issue Validations from QA