Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

[workflow] update linting and release workflows #195

Merged
merged 6 commits into from
Nov 24, 2020
Merged

Conversation

onedr0p
Copy link
Member

@onedr0p onedr0p commented Nov 23, 2020

Special notes for your reviewer:

  • moved ct.yaml to .github directory
  • updated linting workflow and bumped helm/chart-testing-action to v2.0.1
  • updated release workflow and bumped helm/chart-releaser-action to v1.1.0
  • added job after release job to update generated timestamp in index.yaml in the gh-pages branch

Minor issue with helm/chart-releaser-action is this issue helm/chart-releaser-action#61 however I didn't see this behavior in our tests

@onedr0p onedr0p requested a review from bjw-s November 24, 2020 00:04
@onedr0p onedr0p changed the title [workflow] update workflows [workflow] update linting and release workflows Nov 24, 2020
@onedr0p onedr0p marked this pull request as ready for review November 24, 2020 00:15
.github/workflows/lint-test.yaml Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
@onedr0p
Copy link
Member Author

onedr0p commented Nov 24, 2020

All fixed up :)

@onedr0p onedr0p requested a review from bjw-s November 24, 2020 13:20
Copy link
Member

@billimek billimek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onedr0p onedr0p merged commit a05b836 into master Nov 24, 2020
@onedr0p onedr0p deleted the workflow-updates branch November 24, 2020 13:30
@onedr0p
Copy link
Member Author

onedr0p commented Nov 24, 2020

Shipping!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants