Implement ApiVersions message in protocol #319
Conversation
jbruggem
force-pushed
the
api_versions
branch
from
9a0518d
to
5d8a317
Compare
|
Tests pass (though an admin might need to restart some of them) |
|
The follow-up is ready :). It depends on this one so it is based on the same branch. As soon is this one is reviewed and merged, I can open the other one. If anybody is interested: https://github.com/euranova/kafka_ex/tree/use_api_versions_for_new_api_calls |
|
@jbruggem Sorry about the delay in looking at this, I'll probably not be able to take a look until Thursday due to life interfering 😢 |
|
@jbruggem this is looking good, just a few small fixes and it should be ready to merge |
great! Thanks for taking the time to review. |
For `kafka_create_topics` and `kafka_api_versions`.
jbruggem
force-pushed
the
api_versions
branch
from
8d43966
to
675442a
Compare
|
@joshuawscott thanks for the second review :). If you feel it's OK, would you or another maintainer be kind enough to merge ? Thanks ! |
|
@jbruggem sorry about the delay, just making sure none of the other maintainers had any comments |
No problem ! |
Use api versions for new api calls (depends on #319)
Closes #318 .
The support for ApiVersions was actually added in
0.10.0.0, but here I'm adding it to0.10.1.0for the sake of simplicity because it's temporary.I intend to follow this PR with another where I get rid of
server_0_p_10_p_1.exin favor ofserver_0_10_or_later.ex(or some other better name), and then use ApiVersions to check compatibility at runtime.