Use api versions for new api calls (depends on #319) #320
Conversation
jbruggem
force-pushed
the
use_api_versions_for_new_api_calls
branch
from
081de12
to
0f58fbe
Compare
jbruggem
force-pushed
the
use_api_versions_for_new_api_calls
branch
from
0f58fbe
to
b33aa60
Compare
|
This MR is now ready for review ! (as usual, I think the CI tests need to be restarted to allow them to pass) |
lib/kafka_ex/api_versions.ex
Outdated
| def api_versions_map(api_versions) do | ||
| api_versions | ||
| |> Enum.map(fn version -> {version.api_key, version} end) | ||
| |> Map.new |
There was a problem hiding this comment.
This function isn't supported by elixir 1.1
There was a problem hiding this comment.
thanks, I'll fix that. Any idea what to replace it with ?
There was a problem hiding this comment.
From the logs of the CI, it seems I fixed that problem.
There was a problem hiding this comment.
Another option
Enum.into(api_versions, %{}, fn version -> {version.api_key, version} end)There was a problem hiding this comment.
thanks, I keep forgetting about Enum.into !
|
Hey people ! Anybody else apart from Joshua would like to give an opinion on this ? It is rather important in the sense that it alters a bit the way the project will implement future features, following the lead of Kafka since 0.10. |
|
@jbruggem Thanks again! I'll try to get a release together soon |
See #318.
This MR replaces
server_0_p_10_p_1.exbyserver_0_10_or_later.exand uses api versions to handle the API calls implemented in it.This would mean that from here on out, all messages of the API can be implemented without assuming the version of the server. All that is needed is to refer to the
api_versionsto check which is the greatest version of the message supported both by the server and the client.Follow-up to #319