Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension breaks when VS Code Insiders Edition is updated #194

Closed
nikoheikkila opened this issue Feb 1, 2022 · 1 comment
Closed

Extension breaks when VS Code Insiders Edition is updated #194

nikoheikkila opened this issue Feb 1, 2022 · 1 comment

Comments

@nikoheikkila
Copy link

Hi,

When the VS Code Insiders Edition receives a new update (typically many times a week), and I reload the IDE, the extension cannot find the code --wait command anymore and thus errors when entering the commit message window. After updating, I can fix this manually by symlinking the code-insiders to code in my PATH.

I suppose there might be a hard-coded path somewhere that breaks? Using this in WSL Ubuntu 20.04 under Windows 11.
@kahole
Copy link
Owner

kahole commented Jul 11, 2023

Is this still happening?

ianic added a commit to ianic/edamagit that referenced this issue Jul 31, 2023
@ianic
fix vscode-insiders path for the remote environment
b539931 
I'm using vscode insiders from macOS to develop on remote Linux machine.
When I try to commit edamagit fails because it cannot find code
cli.

 'code-insiders' it is in PATH when running terminal from vscode:
```sh
which code-insiders
/home/ianic/.vscode-server-insiders/bin/9800cf6dd6bf4634889d60720ef46a400f3a7298/bin/remote-cli/code-insiders
```

The problem is that edamagit is looking into `../bin/code-insiders`
instead of `../bin/remote-cli/code-insiders`. So it fails to
find it and
[fallback](https://github.com/kahole/edamagit/blob/e9462afbdad4ed0a84ec3b1d92c6a9eb4dd20aa2/src/commands/commitCommands.ts#L212)
to using `code` from PATH. Which works if insiders version is not used.
In insiders version there is no `code` cli in PATH but
`code-insiders`.

I think that [this](kahole#194) issue
has the same root cause.
@ianic ianic mentioned this issue Jul 31, 2023
Merged
@kahole kahole closed this as completed Dec 4, 2023
hedning pushed a commit to hedning/edamagit that referenced this issue Jan 31, 2024
@ianic
fix vscode-insiders path for the remote environment
b26ef2a 
I'm using vscode insiders from macOS to develop on remote Linux machine.
When I try to commit edamagit fails because it cannot find code
cli.

 'code-insiders' it is in PATH when running terminal from vscode:
```sh
which code-insiders
/home/ianic/.vscode-server-insiders/bin/9800cf6dd6bf4634889d60720ef46a400f3a7298/bin/remote-cli/code-insiders
```

The problem is that edamagit is looking into `../bin/code-insiders`
instead of `../bin/remote-cli/code-insiders`. So it fails to
find it and
[fallback](https://github.com/kahole/edamagit/blob/e9462afbdad4ed0a84ec3b1d92c6a9eb4dd20aa2/src/commands/commitCommands.ts#L212)
to using `code` from PATH. Which works if insiders version is not used.
In insiders version there is no `code` cli in PATH but
`code-insiders`.

I think that [this](kahole#194) issue
has the same root cause.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikoheikkila @kahole