Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vscode-insiders path for the remote environment #267

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

ianic
Copy link
Contributor

@ianic ianic commented Jul 31, 2023

I'm using vscode insiders from macOS to develop on remote Linux machine. When I try to commit edamagit fails because it cannot find code cli.

code-insiders it is in PATH when running terminal from vscode:

which code-insiders
/home/ianic/.vscode-server-insiders/bin/9800cf6dd6bf4634889d60720ef46a400f3a7298/bin/remote-cli/code-insiders

The problem is that edamagit is looking into ../bin/code-insiders instead of ../bin/remote-cli/code-insiders. So it fails to find it and fallback to using code from PATH. Which works if insiders version is not used. In insiders version there is no code cli in PATH but code-insiders.

I think that this issue has the same root cause.

I'm using vscode insiders from macOS to develop on remote Linux machine.
When I try to commit edamagit fails because it cannot find code
cli.

 'code-insiders' it is in PATH when running terminal from vscode:
```sh
which code-insiders
/home/ianic/.vscode-server-insiders/bin/9800cf6dd6bf4634889d60720ef46a400f3a7298/bin/remote-cli/code-insiders
```

The problem is that edamagit is looking into `../bin/code-insiders`
instead of `../bin/remote-cli/code-insiders`. So it fails to
find it and
[fallback](https://github.com/kahole/edamagit/blob/e9462afbdad4ed0a84ec3b1d92c6a9eb4dd20aa2/src/commands/commitCommands.ts#L212)
to using `code` from PATH. Which works if insiders version is not used.
In insiders version there is no `code` cli in PATH but
`code-insiders`.

I think that [this](kahole#194) issue
has the same root cause.
@kahole kahole merged commit 0d17f57 into kahole:develop Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants