Skip to content

Commit

Permalink
deps: cherry-pick missing v8 floating patch
Browse files Browse the repository at this point in the history
2d524bc

Original commit message:

  deps: limit regress/regress-crbug-514081 v8 test

  regress/regress-crbug-514081 allocates a 2G block of memory
  and if there  are multiple variants running at the
  same time this can lead to crashes, OOM kills or
  the OS failing to allocate memory.  This patch
  limits us to running a single variant of the test

  Fixes: nodejs/node#6340
  PR-URL: nodejs/node#6678
  Reviewed-By: Ben Noordhuis <[email protected]>
  Reviewed-By: James M Snell <[email protected]>
  Reviewed-By: Fedor Indutny <[email protected]>

PR-URL: nodejs/node#8907
Fixes: nodejs#8750
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
  • Loading branch information
mhdawson committed Oct 5, 2016
1 parent 0ed8839 commit 4b3e4d5
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions deps/v8/test/mjsunit/mjsunit.status
Original file line number Diff line number Diff line change
Expand Up @@ -826,4 +826,13 @@
'big-array-literal': [SKIP],
}], # 'gcov_coverage'

##############################################################################
# This test allocates a 2G block of memory and if there are multiple
# varients this leads kills by the OOM killer, crashes or messages
# indicating the OS cannot allocate memory, exclude for Node.js runs
# re-evalute when we move up to v8 5.1
[ALWAYS, {
'regress/regress-crbug-514081': [PASS, NO_VARIANTS],
}], # ALWAYS

]

0 comments on commit 4b3e4d5

Please sign in to comment.