This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a very useful concept and I would use the heck out of it if it were in Node. |
From the irc conversation, I am +1 on this, and would like to see it rebased on top of https://github.com/misterdjules/node/compare/joyent:v0.12...path-platform?w=1 which reorders the path module to expose platform based semantics -- re #5661 |
chrisdickinson
force-pushed
the
path-parse-fixes
branch
4 times, most recently
from
November 20, 2014 00:57
0cdee30
to
8468714
Compare
Add path.posix and path.win32 which have the specific methods like resolve and normalize so you can specifically normalize or resolve based on the target platform.
The parse() function splits a path and returns an object with the different elements. The format() function is the reverse of this and adds an objects corresponding path elements to make up a string. Fixes nodejs#6976.
chrisdickinson
force-pushed
the
path-parse-fixes
branch
from
November 20, 2014 01:50
8468714
to
c917c04
Compare
chrisdickinson
pushed a commit
that referenced
this pull request
Nov 21, 2014
The parse() function splits a path and returns an object with the different elements. The format() function is the reverse of this and adds an objects corresponding path elements to make up a string. Fixes #6976. Fixes: #6976 PR-URL: #8750 Reviewed-by: Julien Gilli <[email protected]>
Merged in 2d17193. |
kaiquewdev
pushed a commit
to kaiquewdev/node
that referenced
this pull request
Nov 26, 2016
2d524bc Original commit message: deps: limit regress/regress-crbug-514081 v8 test regress/regress-crbug-514081 allocates a 2G block of memory and if there are multiple variants running at the same time this can lead to crashes, OOM kills or the OS failing to allocate memory. This patch limits us to running a single variant of the test Fixes: nodejs/node#6340 PR-URL: nodejs/node#6678 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> PR-URL: nodejs/node#8907 Fixes: nodejs#8750 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #7429.
The feature was originally given the go-ahead by @isaacs.
@roryrjb opened a pr that stalled -- I'm reopening this, having fixed the style issues.
Tested on Win7 + OSX 10.10.
/cc @tjfontaine @indutny
path.parse
Returns an object from a path string.
An example on *nix:
An example on Windows:
path.format
Returns a path string from an object, the opposite of
path.parse
above.