✨ Add a bundle for Project Calico #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdwilsh
changed the title
This adds a bundle for Project Calico, and very basic configuration (only allowing the configuration of the version number). Signed-off-by: Shawn Wilsher <[email protected]>
Tested here: https://regex101.com/r/Xmznbx/1 Signed-off-by: Shawn Wilsher <[email protected]>
mudler
reviewed
Feb 13, 2023
mudler
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
Thanks, this is looking good!
Like you said there are a lot of options indeed for calico, however I think that's a good start, we can also think about passing-by directly values from the helm chart directly from the config, to avoid be specific on each configuration option. Nevertheless, I think that's a good starting point and we can start from here!
I did this in #12. This approach may be useful for other bundles as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a bundle for Project Calico, and allows the configuration of the version to be installed. The version we install by default is managed by renovate.
This technically addresses kairos-io/kairos#640, but I think it is insufficient for now, as we should allow many more configuration options before considering it done.