🤖 Have linting and make it required on every one of Kairos repositories

[mauromorales]

Standards applied on the Kairos main repo should also be required on every other repository. There will be linting steps that might not make sense, those can be ignored, but we should to have this as a standard of our different codebases.

• https://github.com/kairos-io/kairos/ -> Consume reusable linting workflow #1371
• https://github.com/spectrocloud/peg -> Try linting composite action spectrocloud/peg#17
• https://github.com/kairos-io/provider-kairos -> Use re-usable linting workflow provider-kairos#376
• https://github.com/kairos-io/elemental-cli will be merged into kairos so no need to
• https://github.com/kairos-io/immucore
• https://github.com/kairos-io/kcrypt-challenger
• https://github.com/kairos-io/packages.kairos.io
• https://github.com/kairos-io/packages
• https://github.com/kairos-io/kcrypt
• https://github.com/kairos-io/provider-rke2
• https://github.com/kairos-io/provider-kubeadm
• https://github.com/kairos-io/kairos-sdk
• https://github.com/kairos-io/cluster-api-provider-kairos
• https://github.com/kairos-io/AuroraBoot
• https://github.com/kairos-io/community-bundles
• https://github.com/kairos-io/provider-k3s
• https://github.com/kairos-io/helm-charts
• https://github.com/kairos-io/provider-amt
• https://github.com/kairos-io/tpm-helpers
• https://github.com/kairos-io/entangle
• https://github.com/kairos-io/osbuilder
• more?

[Itxaka]

Maybe we could have an action that runs our generic linters so it can be reused in all repos?
That would make everything more centralized and kept all repos in sync?

[mudler]

A small sample of a composite action (that we already use) https://github.com/Luet-lab/luet-install-action

[mauromorales]

ohh I like the idea, thanks for sharing guys

[jimmykarily]

Created a new repo for the action here: https://github.com/kairos-io/linting-composite-action

[mauromorales]

@jimmykarily there's already https://github.com/kairos-io/kairos-linter sorry that I didn't put it here in the ticket. We can use either or, no preference for me but I had already done some progress on the one I mention

[jimmykarily]

Oops 🤦‍♂️ . I started with the same approach by using an Earthfile but then I couldn't find a way to tell Earthly "here is the Earthfile, here is the context dir" like you can do with docker.
Then the problem was that the directory of the action is not the one of the checkout (I think). Anyway, I found it relatively easy to simply run with docker: https://github.com/kairos-io/linting-composite-action/blob/main/action.yml

Let's sync tomorrow

[jimmykarily]

I also think we may need a "reusable workflow" instead of a "composite action" so that all our checks run and it doesn't stop on the first one that failed (as it happened here for example). For that to happen, we need to be able to define "jobs" instead of "steps".

See here: https://dev.to/n3wt0n/composite-actions-vs-reusable-workflows-what-is-the-difference-github-actions-11kd

[jimmykarily]

I created a reusable workflow here: https://github.com/kairos-io/linting-composite-action/blob/main/.github/workflows/reusable-linting.yaml

and tried it out here: spectrocloud/peg#17

It seems to be working fine!

[mauromorales]

Very nice, I'll remove the other repo