Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume reusable linting workflow #1371

Merged
merged 1 commit into from
May 9, 2023
Merged

Consume reusable linting workflow #1371

merged 1 commit into from
May 9, 2023

Conversation

jimmykarily
Copy link
Contributor

part of: #1234

@jimmykarily jimmykarily mentioned this pull request May 3, 2023
Open
20 tasks
@jimmykarily
Copy link
Contributor Author

The hadolint errors were there before but the earthly target has a mistake and didn't catch them. There are legitimate issues we should fix.

@jimmykarily jimmykarily self-assigned this May 3, 2023
@jimmykarily
Copy link
Contributor Author

I'm not sure I agree with the hadolint suggestions:

./images/Dockerfile.opensuse-leap-arm-rpi:9 DL3037 warning: Specify version with `zypper install -y <package>=<version>`.

from here. As far as I know, not every version is available for installation at any given image. It's the responsibility of the distribution to include package versions that "work". I understand builds should be reproducible but I'm not sure pinning the version of every package is doable.

@jimmykarily
Copy link
Contributor Author

I created a .hadolint.yaml file to assign them the severity "info" and then ignore them (not fail on them).

mauromorales
mauromorales approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jimmykarily jimmykarily merged commit 5f90166 into master May 9, 2023
@jimmykarily jimmykarily deleted the 1234-reusable-linting branch May 9, 2023 12:37
@jimmykarily jimmykarily restored the 1234-reusable-linting branch August 17, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauromorales mauromorales mauromorales approved these changes

Assignees

@jimmykarily jimmykarily

Labels
None yet
Projects
🧙Issue tracking board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmykarily @mauromorales