Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 nohang service fails on Ubuntu 23.10 #2195

Closed
mauromorales opened this issue Jan 30, 2024 · 3 comments · Fixed by #2318
Closed

🐛 nohang service fails on Ubuntu 23.10 #2195

mauromorales opened this issue Jan 30, 2024 · 3 comments · Fixed by #2318
Labels
blocked bug Something isn't working

Comments

@mauromorales
Copy link
Member

tried with the alpha but I found this issue already on 2.5.0

PRETTY_NAME="Ubuntu 23.10"
NAME="Ubuntu"
VERSION_ID="23.10"
VERSION="23.10 (Mantic Minotaur)"
VERSION_CODENAME=mantic
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=mantic
LOGO=ubuntu-logo
KAIROS_VERSION_ID="v3.0.0-alpha1-v1.29.0-k3s1"
KAIROS_ARTIFACT="kairos-ubuntu-23.10-standard-amd64-generic-v3.0.0-alpha1-k3sv1.29.0+k3s1"
KAIROS_FLAVOR_RELEASE="23.10"
KAIROS_MODEL="generic"
KAIROS_REGISTRY_AND_ORG="quay.io/kairos"
KAIROS_BUG_REPORT_URL="https://github.com/kairos-io/kairos/issues"
KAIROS_SOFTWARE_VERSION="v1.29.0+k3s1"
KAIROS_NAME="kairos-standard-ubuntu-23.10"
KAIROS_IMAGE_REPO="quay.io/kairos/ubuntu:23.10-standard-amd64-generic-v3.0.0-alpha1-k3sv1.29.0-k3s1"
KAIROS_RELEASE="v3.0.0-alpha1"
KAIROS_ID="kairos"
KAIROS_FLAVOR="ubuntu"
KAIROS_VARIANT="standard"
KAIROS_TARGETARCH="amd64"
KAIROS_HOME_URL="https://github.com/kairos-io/kairos"
KAIROS_SOFTWARE_VERSION_PREFIX="k3s"
KAIROS_VERSION="v3.0.0-alpha1-v1.29.0-k3s1"
KAIROS_ID_LIKE="kairos-standard-ubuntu-23.10"
KAIROS_PRETTY_NAME="kairos-standard-ubuntu-23.10 v3.0.0-alpha1-v1.29.0-k3s1"
KAIROS_IMAGE_LABEL="23.10-standard-amd64-generic-v3.0.0-alpha1-k3sv1.29.0-k3s1"
KAIROS_GITHUB_REPO="kairos-io/kairos"

nohang status

root@localhost:/home/kairos# systemctl status --failed
× nohang-desktop.service - Sophisticated low memory handler
     Loaded: loaded (/lib/systemd/system/nohang-desktop.service; enabled; preset: enabled)
     Active: failed (Result: exit-code) since Tue 2024-01-30 09:18:27 UTC; 57s ago
   Duration: 140ms
       Docs: man:nohang(8)
             https://github.com/hakavlad/nohang
   Main PID: 1607 (code=exited, status=1/FAILURE)
        CPU: 137ms

Jan 30 09:18:27 localhost systemd[1]: nohang-desktop.service: Scheduled restart job, restart counter is at 5.
Jan 30 09:18:27 localhost systemd[1]: Stopped nohang-desktop.service - Sophisticated low memory handler.
Jan 30 09:18:27 localhost systemd[1]: nohang-desktop.service: Start request repeated too quickly.
Jan 30 09:18:27 localhost systemd[1]: nohang-desktop.service: Failed with result 'exit-code'.
Jan 30 09:18:27 localhost systemd[1]: Failed to start nohang-desktop.service - Sophisticated low memory handler.

Seems to be related to hakavlad/nohang#135 so we might need to bump the version once it is released. Or maybe we can even provide it as part of the framework image like suggested here #1609 (comment)

@mauromorales mauromorales added the bug Something isn't working label Jan 30, 2024
@mauromorales mauromorales assigned mudler and unassigned mudler Jan 30, 2024
@mauromorales mauromorales added the triage Add this label to issues that should be triaged and prioretized in the next planning call label Jan 30, 2024
@mauromorales
Copy link
Member Author

Kevin tested this with a new cluster, and it spins up fine. I don't understand how we use nohang exactly, so not sure if it's an issue. We will only find out with a loaded cluster, or if nohang is used for something specific that needs to be tested

@jimmykarily jimmykarily removed the triage Add this label to issues that should be triaged and prioretized in the next planning call label Feb 6, 2024
@liyimeng
Copy link
Contributor

liyimeng commented Feb 16, 2024

upstream have a fix for this hakavlad/nohang#136, hope new release of nohang fix the issue.

@liyimeng
Copy link
Contributor

liyimeng commented Mar 8, 2024

Today, we install nohang from ppa, which might not up to date. I think would consider to install it from source, we then have the fix.

liyimeng added a commit to liyimeng/kairos that referenced this issue Mar 8, 2024
nohang apt repo is not actively maintained, install it from source instead.

try to fix kairos-io#2195

Signed-off-by: Liyi Meng <[email protected]>
liyimeng added a commit to liyimeng/kairos that referenced this issue Mar 8, 2024
nohang apt repo is not actively maintained, install it from source instead.

try to fix kairos-io#2195

Signed-off-by: Liyi Meng <[email protected]>
mauromorales added a commit that referenced this issue Mar 12, 2024
* Install nohang from source for ubuntu

nohang apt repo is not actively maintained, install it from source instead.

try to fix #2195

Signed-off-by: Liyi Meng <[email protected]>

* Refactoring

1. We don't need zfs on UKI images
2. gnupg is not needed in common
3. Renaming of targets to legacy and current, to re-use between 22+
   versions

Signed-off-by: Mauro Morales <[email protected]>

* Re-generate Dockerfile.kairos-ubuntu

Signed-off-by: Mauro Morales <[email protected]>

* Lint

Signed-off-by: Mauro Morales <[email protected]>

---------

Signed-off-by: Liyi Meng <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
Co-authored-by: Mauro Morales <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants