-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Build provider-kairos in this repository #1609
Comments
Currently the process to build provider enabled images on kairos is done via earthfile by running the command: Which:
This is set by running the earthly command with the flag ISO naming is currently not changed, so that needs to be fixed. It will generate the same iso name as one without the provider on it, but as its used for testing only it did not matter that much. Also as we are on earthly 0.6 the ARG values cannot be override inside a target. So we cannot just override the |
as part of this: kairos-io/kairos#1609 Signed-off-by: Dimitris Karakasilis <[email protected]>
as part of this: kairos-io/kairos#1609 Signed-off-by: Dimitris Karakasilis <[email protected]>
so that we can call it to verify we built a fips version by greping for "boringcrypto" in the output. Part of: kairos-io/kairos#1609 Will be used here: kairos-io/packages#334 Signed-off-by: Dimitris Karakasilis <[email protected]>
Provider kairos has a luet package: https://github.com/kairos-io/packages/tree/main/packages/bundles/provider-kairos but the k3s one doesn't do all the things described on Itxaka's comment above (e.g. it doesn't create the services files), it's in TODO) We can try to finish the k3s package and use it but I wonder if it would be better to actually call the the k3s installer script from within the luet package instead. Are we breaking some convention if a luet package makes calls to the internet? Is it supposed to be self-contained? I'm thinking that if we don't do this, we would need to always follow the logic of the installer script and make sure we replicate the same result in the luet package. |
The existing package already downloads k3s: https://github.com/kairos-io/packages/blob/fddf0ce68bf92c9dab71991ceb6d86e2c355e991/packages/k3s/build.yaml#L9 We could as well do this in the package: https://github.com/kairos-io/provider-kairos/blob/9f56a5578bfee5d0d0018d4eba7686a19939f7fb/Earthfile#L168-L172 |
so that we can call it to verify we built a fips version by greping for "boringcrypto" in the output. Part of: kairos-io/kairos#1609 Will be used here: kairos-io/packages#334 --------- Signed-off-by: Dimitris Karakasilis <[email protected]>
…os (#472) TODO: Build standard images for all flavors in kairos on "master", so that we can completely remove the image building code from this repo (and the rest of the image building pipelines). This way, there won't be any duplication anymore. Part of [#1609](kairos-io/kairos#1609) Goes together with: kairos-io/kairos#1689 Signed-off-by: Dimitris Karakasilis <[email protected]>
Continuation of : #1557
We have moved the provider-kairos tests to kairos, this card is about moving the release process into kairos
Action items
Open points to check:
The text was updated successfully, but these errors were encountered: