Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for RPI3 for alpine flavor #1820

Closed
wants to merge 77 commits into from
Closed

add support for RPI3 for alpine flavor #1820

wants to merge 77 commits into from

Conversation

Ludea
Copy link
Contributor

@Ludea Ludea commented Sep 14, 2023

What this PR does / why we need it:
Add support for RP3

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
With 2.4 release, RPI3 and RPI4 get separate img

@Itxaka
Copy link
Member

Itxaka commented Sep 14, 2023

Looks good. We may need to change some things before getting this merged to separate the rpi images and artifacts into 2 different repos maybe as not sure if the artifacts have the proper naming to be alongside...

@Ludea
Copy link
Contributor Author

Ludea commented Sep 14, 2023

+base-image | linux/arm64 | FLAVOR=opensuse-leap-arm-rpi MODEL=rpi4 VARIANT=core => https://github.com/kairos-io/kairos/actions/runs/6185486007/job/16791177481#step:14:2663
seems model var is not updated for base-image

@Ludea
Copy link
Contributor Author

Ludea commented Sep 14, 2023

there is also
common | System has not been booted with systemd as init system (PID 1). Can't operate. common | Failed to connect to bus: Host is down common | done]

@Itxaka
Copy link
Member

Itxaka commented Sep 14, 2023

there is also common | System has not been booted with systemd as init system (PID 1). Can't operate. common | Failed to connect to bus: Host is down common | done]

default build for prs is rpi4 and just one flavor :)
This would be reflected on master jobs which run the full flavor suite: https://github.com/kairos-io/kairos/blob/master/.github/workflows/image-arm.yaml#L25

@Ludea
Copy link
Contributor Author

Ludea commented Sep 14, 2023

Looks good. We may need to change some things before getting this merged to separate the rpi images and artifacts into 2 different repos maybe as not sure if the artifacts have the proper naming to be alongside...

https://github.com/kairos-io/kairos/actions/runs/6185486007/job/16791177481#step:14:32128
it's tagged with rpi4

@Itxaka
Copy link
Member

Itxaka commented Sep 14, 2023

Looks good. We may need to change some things before getting this merged to separate the rpi images and artifacts into 2 different repos maybe as not sure if the artifacts have the proper naming to be alongside...

kairos-io/kairos/actions/runs/6185486007/job/16791177481#step:14:32128 it's tagged with rpi4

yes, on PRs we only build that: https://github.com/kairos-io/kairos/blob/master/.github/workflows/image-arm-pr.yaml#L19

@jimmykarily jimmykarily mentioned this pull request Sep 18, 2023
Closed
@mudler mudler requested a review from Itxaka September 18, 2023 09:14
@Itxaka
Copy link
Member

Itxaka commented Sep 18, 2023

tested this locally and it builds the image as expected buuuuut.... we dont set the output repo properly:

quay.io/kairos/core-alpine-arm-rpi:v2.4.0-5-gd252ef2

This means that if we build alpine-arm-rpi for both rpi3 and rpi4 they will get mixed and with no way of knowing which image is what...

@Itxaka
Copy link
Member

Itxaka commented Sep 18, 2023

This will probably need to wait for #1694 as we are renaming the repos, so we may do the distinction there somehow

@Itxaka Itxaka mentioned this pull request Sep 18, 2023
Closed
Ludea and others added 19 commits October 27, 2023 08:16
@Ludea
add support for RPI3 for alpine flavor
4842529 
Signed-off-by: Ludea <[email protected]>
@jimmykarily @Ludea
Pick the right artifact from releases
a948c57 
because the artifact names have changed in the last release and the
globbing of release-dowloader is not that smart

Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Ludea <[email protected]>
@jimmykarily @Ludea
One more CI fix :(
fd04b23 
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
🐛 Provide a generic bootargs in the framework for fips (#1818)
493203a 
Signed-off-by: Ludea <[email protected]>
@ci-robbot @jimmykarily @Ludea
⬆️ Update repositories (#1822)
3f18845 
Signed-off-by: GitHub <[email protected]>
Co-authored-by: jimmykarily <[email protected]>
Signed-off-by: Ludea <[email protected]>
@ci-robbot @mudler @Ludea
⬆️ Update repositories (#1825)
7019420 
Co-authored-by: mudler <[email protected]>
Signed-off-by: Ludea <[email protected]>
@renovate @Ludea
Update aquasec/trivy Docker tag to v0.45.1 (#1826)
f333a6d 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Ludea <[email protected]>
@renovate @Ludea
Update docker/login-action action to v3 (#1812)
d5c8e65 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Ludea <[email protected]>
@renovate @Ludea
Update docker/setup-buildx-action action to v3 (#1813)
9a2dc86 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Ludea <[email protected]>
@jimmykarily @Ludea
Change where systemd-sysext extensions are installed (#1823)
25e830e 
Part of: #1821

Needs this: kairos-io/packages#437

TODO: Documentation update. E.g. https://kairos.io/docs/advanced/livelayering/#installing-extensions

Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
✨ Build uki iso artifacts (#1832)
a8c3ef3 
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
📖 Fix ubuntu fips example (#1834)
9ab65b5 
Signed-off-by: Ludea <[email protected]>
@jimmykarily @Ludea
Use the upstream luet-install-action again (#1835)
ff5e168 
after fix has been merged

Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
⬆️ Bump repos and change layout package category (#1840)
eb94dc0 
bundles/kairos-overlay-files is now static/kairos-overlay-files

Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
Single magical bootargs (#1824)
4a6911b 
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
🤖 Fix systemd-fips framework trying to copy non-existing file (#1844)
e406757 
Signed-off-by: Ludea <[email protected]>
@renovate @Ludea
Update earthly/earthly Docker tag to v0.7.19 (#1833)
64ca2be 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Ludea <[email protected]>
@mauromorales @Ludea
Do not remove cache dir (#1855)
d86bc09 
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Ludea <[email protected]>
@ci-robbot @mudler @Ludea
⬆️ Update repositories (#1845)
c586fb3 
Signed-off-by: GitHub <[email protected]>
Co-authored-by: mudler <[email protected]>
Signed-off-by: Ludea <[email protected]>
Itxaka and others added 26 commits October 27, 2023 08:16
@Itxaka @Ludea
🤖 Fix workflow for image
3ab627f 
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Ludea <[email protected]>
@mauromorales @Ludea
Introduce RHEL family (#1953)
7ae00fd 
* Introduce RHEL family

- merges the files for rockylinux and almalinux into a rhel dockerfile
- decided not to add fedora into this since, it requires to add the epel packages, which might make fedora too close to rhel for our community users. But wonder what you think, is it a good/bad idea to try to also merge that one?

Clean up fedora dockerfile

- remove packages which are already installed by default "coreutils" and "curl"
- make it similar to the other dockerfiles for easier maintenance

Signed-off-by: Mauro Morales <[email protected]>

* Add fedora to rhel family

Signed-off-by: Mauro Morales <[email protected]>

* Introduce inbetween stage for readability

Signed-off-by: Mauro Morales <[email protected]>

---------

Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
🤖 Run bundles test on tumbleweed (#1961)
8c3554b 
Signed-off-by: Ludea <[email protected]>
@mauromorales @Ludea
Merge opnesuse families into one (#1957)
abfedc7 
* Merge opnesuse families into one

Signed-off-by: Mauro Morales <[email protected]>

* Fix issue with rpi

Signed-off-by: Mauro Morales <[email protected]>

---------

Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
🎨 Build alpine initrd during image building (#1924)
7480b09 
Signed-off-by: Ludea <[email protected]>
@mauromorales @Ludea
🐛 Fix Dockerfile for ubuntu 20 lts non-hwe (#1927)
985ac10 
Fix Dockerfile for ubuntu 20 lts non-hwe

Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
🤖 Fix leftovers from alpine PR (#1923)
56e5567 
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
🎨 Use a single framework image (#1929)
9bc4ec8 
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
🤖 Fix image workflow (#1936)
6ab73b0 
Signed-off-by: Ludea <[email protected]>
@ci-robbot @Itxaka @Ludea
⬆️ Update repositories (#1940)
d853fb6 
Co-authored-by: Itxaka <[email protected]>
Signed-off-by: Ludea <[email protected]>
@mauromorales @Ludea
Lint yaml indentation (#1944)
f72f4c7 
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Ludea <[email protected]>
@mauromorales @Ludea
🤖 Apply base image fixes to arm (#1943)
19df9af 
Apply base image fixes to arm

Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Ludea <[email protected]>
@jimmykarily @mauromorales @Ludea
1898 byoi (#1912)
9f15a6a 
* Refactor flavors and dockerfiles

Fixes #1898

Signed-off-by: Dimitris Karakasilis <[email protected]>

* Use FRAMEWORK_FLAVOR variable to avoid confusion with FLAVOR

Signed-off-by: Dimitris Karakasilis <[email protected]>

* Fix pipeline by adding mandatory value

Signed-off-by: Dimitris Karakasilis <[email protected]>

* Fix ubuntu Dockerfile

Signed-off-by: Dimitris Karakasilis <[email protected]>

* Apply suggestions from code review

Signed-off-by: Dimitris Karakasilis <[email protected]>

* Remove TODO (already implemented) and non-used ARG "IMAGE"

Signed-off-by: Dimitris Karakasilis <[email protected]>

* Remove TODOs

moved here: #1897 (comment)

Signed-off-by: Dimitris Karakasilis <[email protected]>

* Remove unecessary env variables and fix VARIANT_RELEASE missing

Signed-off-by: Dimitris Karakasilis <[email protected]>

* PR comments

Signed-off-by: Dimitris Karakasilis <[email protected]>

* Remove naming.sh script from base image

Signed-off-by: Dimitris Karakasilis <[email protected]>

* Make sure we use the "fixed" kairos version with the remove "+" symbols

when creating a tag for container images.

Signed-off-by: Dimitris Karakasilis <[email protected]>

* Setup qemu and docker buildx in reusable-build-flavor workflow

because otherwise it fails to build rpi images

Signed-off-by: Dimitris Karakasilis <[email protected]>

* Remove not needed env variables

Signed-off-by: Dimitris Karakasilis <[email protected]>

* Remove temporary change

Signed-off-by: Dimitris Karakasilis <[email protected]>

---------

Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Co-authored-by: Mauro Morales <[email protected]>
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
🤖 Fix security scans missing from master build (#1948)
774f334 
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
🤖 Drop uki test as its no longer valid (#1949)
405ce5c 
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
🤖 Do not push for now in master
aff059a 
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
🤖 set pushing to false for now on master
a936eb4 
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
🐛 Install ca-certificates on debian base image first (#1952)
753c43f 
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
⬆️ Bump repos
1650ae7 
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
🤖 Fix artifacts names
3b5db74 
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
🤖 Use family to identify the isos
96a87ce 
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
🤖 Fix workflow for image
07745d1 
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Ludea <[email protected]>
@mauromorales @Ludea
Introduce RHEL family (#1953)
d6ff6d4 
* Introduce RHEL family

- merges the files for rockylinux and almalinux into a rhel dockerfile
- decided not to add fedora into this since, it requires to add the epel packages, which might make fedora too close to rhel for our community users. But wonder what you think, is it a good/bad idea to try to also merge that one?

Clean up fedora dockerfile

- remove packages which are already installed by default "coreutils" and "curl"
- make it similar to the other dockerfiles for easier maintenance

Signed-off-by: Mauro Morales <[email protected]>

* Add fedora to rhel family

Signed-off-by: Mauro Morales <[email protected]>

* Introduce inbetween stage for readability

Signed-off-by: Mauro Morales <[email protected]>

---------

Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Ludea <[email protected]>
@Itxaka @Ludea
🤖 Run bundles test on tumbleweed (#1961)
09a25a1 
Signed-off-by: Ludea <[email protected]>
@mauromorales @Ludea
Merge opnesuse families into one (#1957)
b9c78fb 
* Merge opnesuse families into one

Signed-off-by: Mauro Morales <[email protected]>

* Fix issue with rpi

Signed-off-by: Mauro Morales <[email protected]>

---------

Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Ludea <[email protected]>
@Ludea
use new flavors workflow
5795025 
Signed-off-by: Ludea <[email protected]>
@Ludea Ludea closed this Oct 27, 2023
@Ludea Ludea deleted the rpi3 branch October 27, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Itxaka Itxaka Awaiting requested review from Itxaka

Assignees

@Ludea Ludea

Labels
arm/rpi
Projects
🧙Issue tracking board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ludea @Itxaka @mauromorales @jimmykarily @ci-robbot