feat(FEC-11761): expose stream timed metadata - phase 2 #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyBregman
reviewed
Jan 10, 2022
src/track/cue-point.js
Outdated
| @@ -27,6 +27,7 @@ class CuePoint { | |||
| CuePoint.TYPE = { | |||
| ID3: 'id3', | |||
| EMSG: 'emsg', | |||
| CUE_POINT: 'cuepoint', | |||
There was a problem hiding this comment.
CuePount.Type.CUE_POINT?
There was a problem hiding this comment.
agree it's wired but this is how cuepoint manager works. it generates a cue point of type 'cuepoint'.
RoyBregman
reviewed
Jan 10, 2022
RoyBregman
reviewed
Jan 10, 2022
Comment on lines
+13
to
+26
| export function binarySearch(list: Array<any> = [], comparisonFn: Function = () => 1): any { | ||
| if (list.length === 0 || (list.length === 1 && comparisonFn(list[0]) !== 0)) { | ||
| return null; | ||
| } | ||
| const mid = Math.floor(list.length / 2); | ||
| if (comparisonFn(list[mid]) === 0) { | ||
| return list[mid]; | ||
| } | ||
| if (comparisonFn(list[mid]) > 0) { | ||
| return binarySearch(list.slice(0, mid), comparisonFn); | ||
| } else { | ||
| return binarySearch(list.slice(mid + 1), comparisonFn); | ||
| } | ||
| } |
There was a problem hiding this comment.
What does this have to do with this feat?
There was a problem hiding this comment.
This was referenced Jan 11, 2022
yairans
added a commit
to kaltura/playkit-js-dash
that referenced
this pull request
Jan 12, 2022
use the new structure of `TimedMetadata` Solves FEC-11761 Depends on kaltura/playkit-js#623
yairans
added a commit
to kaltura/playkit-js-hls
that referenced
this pull request
Jan 12, 2022
Fire `TIMED_METADATA_ADDED` once a new id3 cue has been added Solves FEC-11761 Depends on kaltura/playkit-js#623
yairans
added a commit
to kaltura/kaltura-player-js
that referenced
this pull request
Jan 12, 2022
use `TimedMetadata` from core Change cuePointManager API's to use `TimedMetadata` instead of `VttCue` Solves FEC-11761 Depends on kaltura/playkit-js#623 Breaking Change for - kaltura/playkit-js-dual-screen#52 kaltura/playkit-js-kaltura-cuepoints#15
borhandarabi
pushed a commit
to TasvirChi/playchi-js-dash
that referenced
this pull request
May 14, 2024
use the new structure of `TimedMetadata` Solves FEC-11761 Depends on kaltura/playkit-js#623
borhandarabi
pushed a commit
to TasvirChi/playchi-js-hls
that referenced
this pull request
May 14, 2024
Fire `TIMED_METADATA_ADDED` once a new id3 cue has been added Solves FEC-11761 Depends on kaltura/playkit-js#623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
TimedMetadatainstead ofCuePointTIMED_METADATA_CHANGEevent which triggered when withTIMED_METADATAbut with payload ofTimedMetadataarray instead ofVttCuearraytrack.labeland merge all metadata tracks cues instead (reverts fix(FEC-11606): Add TextTrack label to TIMED_METADATA event payload #609, closes fix(FEC-11606): merge active cue-points from all metadata TextTracks #610)createTimedMetadatato create aTimedMetadatabased onVttCuebinarySearch(for feat(FEC-11761): expose stream timed metadata - phase 2 playkit-js-hls#157)Solves FEC-11761
Related to -
kaltura/playkit-js-hls#157
kaltura/playkit-js-dash#174
kaltura/kaltura-player-js#512
kaltura/playkit-js-dual-screen#52
kaltura/playkit-js-kaltura-cuepoints#15
CheckLists