Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty captions menu when playing native hls #153

Merged
merged 5 commits into from
Oct 29, 2017
Merged

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Oct 29, 2017

Description of the Changes

Sometimes, when playing native hls on Safari, text tracks are not ready on loadeddata event. If this the case, we will wait for canplay event and parse the tracks right after.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan-ziv the flow linter is failing the test, please fix

@dan-ziv dan-ziv merged commit 623d83a into master Oct 29, 2017
@dan-ziv dan-ziv deleted the fix-empty-menu branch October 29, 2017 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants