Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to launch different versions of Firefox #125

Closed
pantosha opened this issue Oct 31, 2020 · 4 comments · Fixed by #126
Closed

Provide a way to launch different versions of Firefox #125

pantosha opened this issue Oct 31, 2020 · 4 comments · Fixed by #126
Labels

Comments

@pantosha
Copy link
Contributor

pantosha commented Oct 31, 2020

We need to test site in different versions of Firefox in parallel.
So it will be nice to provide an option to configure path to Firefox executables.

Possible way to implement is extending of args for customLaunchers.

customLaunchers: {
    Firefox68: {
        base: 'FirefoxHeadless',
        name: 'Firefox68',
        command: '<path to FF68>/firefox.exe'
    },
    Firefox78: {
        base: 'FirefoxHeadless',
        name: 'Firefox78',
        command: '<path to FF78>/firefox.exe'
    }
}
pantosha pushed a commit to pantosha/karma-firefox-launcher that referenced this issue Oct 31, 2020
pantosha added a commit to pantosha/karma-firefox-launcher that referenced this issue Oct 31, 2020
pantosha added a commit to pantosha/karma-firefox-launcher that referenced this issue Oct 31, 2020
pantosha added a commit to pantosha/karma-firefox-launcher that referenced this issue Oct 31, 2020
@birtles
Copy link
Collaborator

birtles commented Nov 2, 2020

I'm just curious, is there a reason to prefer this over triggering the test suite several times using the environment variables?

FIREFOX_BIN=<path to FF68>/firefox.exe yarn test
FIREFOX_BIN=<path to FF72>/firefox.exe yarn test

The patch seems good but I'm just curious about the use case.

@pantosha
Copy link
Contributor Author

pantosha commented Nov 2, 2020

@birtles we have a big bunch of tests and we want to run tests in parallel (see karma concurrency option: http://karma-runner.github.io/5.2/config/configuration-file.html). Environment variables can't help us in that case.

@birtles
Copy link
Collaborator

birtles commented Nov 2, 2020

Thanks. That makes sense.

pantosha added a commit to pantosha/karma-firefox-launcher that referenced this issue Nov 2, 2020
karmarunnerbot pushed a commit that referenced this issue Nov 3, 2020
# [2.1.0](v2.0.0...v2.1.0) (2020-11-03)

### Features

* provide a way to configure location of executable in customLauncher (fix [#125](#125)) ([c53efcc](c53efcc))
@karmarunnerbot
Copy link
Member

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants