Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to configure location of executable in customLauncher #126

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

pantosha
Copy link
Contributor

Fix #125

@google-cla
Copy link

google-cla bot commented Oct 31, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@pantosha pantosha force-pushed the issue-125 branch 3 times, most recently from 59dc4c1 to 9d4086c Compare October 31, 2020 14:53
@birtles
Copy link
Collaborator

birtles commented Nov 2, 2020

This looks great. Mind updating the commit message to 'feat:' instead of 'fix:'? I think this counts as a feature?

@pantosha
Copy link
Contributor Author

pantosha commented Nov 2, 2020

This looks great. Mind updating the commit message to 'feat:' instead of 'fix:'? I think this counts as a feature?

@birtles, fixed

@birtles
Copy link
Collaborator

birtles commented Nov 3, 2020

This looks great. Mind updating the commit message to 'feat:' instead of 'fix:'? I think this counts as a feature?

@birtles, fixed

Thanks!

@birtles birtles merged commit c53efcc into karma-runner:master Nov 3, 2020
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to launch different versions of Firefox
3 participants