Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download Leaflet page #151

Closed
gubuntu opened this issue Mar 15, 2017 · 4 comments · Fixed by #344
Closed

Download Leaflet page #151

gubuntu opened this issue Mar 15, 2017 · 4 comments · Fixed by #344
Assignees
@boney-bun
Labels
API WBExtension
Milestone
Sprint 2

Comments

@gubuntu
Copy link

gubuntu commented Mar 15, 2017

Download ready to use leaflet page which references a layer via tile service. The implementation here would make it trivial to add a map hosted by GeoNode in a different web site. JavaScript references will be done using CDN (Content Distribution Network) references so that there are no local hosting requirements and the html can be directly inserted into a content management system. Implemented for QGIS Backend only.
@gubuntu gubuntu added this to the Sprint 2 milestone Mar 15, 2017
@gubuntu gubuntu added the API label Jun 22, 2017
@gubuntu gubuntu added the ready label Jul 6, 2017
@lucernae
Copy link
Collaborator

lucernae commented Jul 6, 2017

From what I read, it seems you want to download some kind of leaflet html code with layers embedded?

Is this specification ok?

  • The html code will only provides standard leaflet plugins (not like what we see in Geonode's layer details, where there are many 3rd party plugins.)
  • Does this in the format of iframe, or just plain static html?

@gubuntu
Copy link
Author

gubuntu commented Jul 8, 2017 •
edited
Loading

It must be a full static html page.

The div element is #153

The iframe download is #152

@gubuntu gubuntu mentioned this issue Sep 3, 2017
Closed
@gubuntu gubuntu assigned boney-bun and unassigned lucernae Sep 6, 2017
@gubuntu gubuntu added in progress and removed ready labels Sep 6, 2017
@gubuntu
Copy link
Author

gubuntu commented Sep 21, 2017

@boney-bun have you started on this? Should be a simple variation of the iframe and embed widget downloads

boney-bun added a commit to boney-bun/geonode that referenced this issue Sep 26, 2017
@boney-bun
embed full static HTML page as leaflet page
1800293 
fix kartoza#151
@boney-bun boney-bun mentioned this issue Sep 26, 2017
Merged
@gubuntu gubuntu changed the title Download Leaflet widget Download Leaflet page Sep 27, 2017
boney-bun added a commit to boney-bun/geonode that referenced this issue Oct 10, 2017
@boney-bun
Merge branch 'master-qgis_server' into download-leaflet-page-kartoza#151
53ab0f2
boney-bun added a commit to boney-bun/geonode that referenced this issue Oct 13, 2017
@boney-bun
Merge branch 'master-qgis_server' into download-leaflet-page-kartoza#151
4cf353d
boney-bun added a commit to boney-bun/geonode that referenced this issue Oct 13, 2017
@boney-bun
Merge branch 'master-qgis_server' into download-leaflet-page-kartoza#151
d4e467f
boney-bun added a commit that referenced this issue Oct 14, 2017
@boney-bun
Download leaflet page #151 (#344)
55483f3 
* embed full static HTML page as leaflet page
* removes unnecessary comments
* add test case for download leaflet page
* fix reverse for geoserver
* fix travis error on geoserver

fix #151
@boney-bun boney-bun reopened this Oct 14, 2017
@gubuntu
Copy link
Author

gubuntu commented Oct 20, 2017

passed test

although it is incomplete (#365), let's get this delivered

@gubuntu gubuntu closed this as completed Oct 20, 2017
@gubuntu gubuntu removed the testing label Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boney-bun boney-bun

Labels
API WBExtension
Projects
None yet
Milestone
Sprint 2
Development

Successfully merging a pull request may close this issue.

Download leaflet page #151 boney-bun/geonode
3 participants
@gubuntu @lucernae @boney-bun