Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grab an iframe embed snippet #152

Closed
gubuntu opened this issue Mar 15, 2017 · 6 comments · Fixed by #313, #343 or #345
Closed

Grab an iframe embed snippet #152

gubuntu opened this issue Mar 15, 2017 · 6 comments · Fixed by #313, #343 or #345
Assignees
@boney-bun
Labels
WBExtension
Milestone
Mozambique

Comments

@gubuntu
Copy link

gubuntu commented Mar 15, 2017 •
edited
Loading

Grab an iframe embed snippet for inclusion of a map in another site. This is a variant of the approach in #151 but instead of providing a full html document for inclusion in the user’s web site, we will instead provide an iframe snippet that will directly embed the map view in the user’s web site. Implemented for QGIS Backend only.

child of #457
@gubuntu gubuntu added this to the Sprint 2 milestone Mar 15, 2017
@gubuntu gubuntu added the ready label Aug 10, 2017
boney-bun added a commit to boney-bun/geonode that referenced this issue Aug 21, 2017
@boney-bun
embed iframe when viewing a map
c56fcff 
fix kartoza#152
This was referenced Aug 21, 2017
Merged
Merged
boney-bun added a commit to boney-bun/geonode that referenced this issue Aug 21, 2017
@boney-bun
fix link url in iframe
1bdea98 
fix kartoza#152
boney-bun added a commit to boney-bun/geonode that referenced this issue Sep 13, 2017
@boney-bun
Merge branch 'master-qgis_server' into add-iframe-embed-snippet-karto…
70de418 
…za#152
boney-bun added a commit that referenced this issue Sep 14, 2017
@boney-bun
embed iframe when viewing a map (#313)
546c236 
embed iframe when viewing a map

fix #152
@gubuntu gubuntu mentioned this issue Sep 21, 2017
Closed
@gubuntu gubuntu reopened this Sep 23, 2017
@timlinux
Copy link

The implementation does not work for me:

screen shot 2017-09-24 at 1 15 24 pm

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Frame-Options

@timlinux
Copy link

Above should be a 2 minute fix using https://stackoverflow.com/a/33267908

boney-bun added a commit to boney-bun/geonode that referenced this issue Sep 24, 2017
@boney-bun
allow cross-origin resource sharing (CROS) when embedding map
9c6edc7 
fix kartoza#152 and fix kartoza#153
@boney-bun boney-bun mentioned this issue Sep 24, 2017
Merged
boney-bun added a commit that referenced this issue Sep 24, 2017
@boney-bun
allow cross-origin resource sharing (CROS) when embedding map (#343)
9c64bb7 
fix #152 and fix #153
@boney-bun boney-bun removed the testing label Sep 24, 2017
@boney-bun boney-bun reopened this Sep 24, 2017
@boney-bun boney-bun mentioned this issue Sep 26, 2017
Merged
boney-bun added a commit to boney-bun/geonode that referenced this issue Sep 27, 2017
@boney-bun
bug fix embed widget
33ffa14 
the previous code still encountered problem with CORS

this solve the problem

fix kartoza#152
boney-bun added a commit to boney-bun/geonode that referenced this issue Sep 27, 2017
@boney-bun
embed widget link for qgis-server and geoserver backend
d5fdb98 
embed widget link and add copy button

fix kartoza#152
boney-bun added a commit to boney-bun/geonode that referenced this issue Sep 28, 2017
@boney-bun
Merge branch 'master-qgis_server' into bug-fix-embed-widget-kartoza#152
f3ddf9c
boney-bun added a commit to boney-bun/geonode that referenced this issue Oct 10, 2017
@boney-bun
Merge branch 'master-qgis_server' into bug-fix-embed-widget-kartoza#152
3a4cf9d
boney-bun added a commit to boney-bun/geonode that referenced this issue Oct 17, 2017
@boney-bun
Merge branch 'master-qgis_server' into bug-fix-embed-widget-kartoza#152
d7b7674
boney-bun added a commit that referenced this issue Oct 18, 2017
@boney-bun
bug fix embed widget (#345)
8ae1950 
* bug fix embed widget, the previous code still encountered problem with CORS
* fix travis error
* embed widget link for qgis-server and geoserver backend
* embed widget link and add copy button
* refactor map projection on the frontend into django views

fix #152
@boney-bun boney-bun removed the testing label Oct 18, 2017
@boney-bun boney-bun reopened this Oct 18, 2017
@gubuntu
Copy link
Author

gubuntu commented Oct 20, 2017

broken
Screen Shot 2017-10-20 at 18.22.23.png

@gubuntu gubuntu modified the milestones: Sprint 2, Mozambique May 8, 2018
boney-bun added a commit to boney-bun/geonode that referenced this issue Jun 19, 2018
@boney-bun
fix map functionalities
61dc144 
fix kartoza#207

fix kartoza#390

fix kartoza#152
@boney-bun boney-bun mentioned this issue Jun 19, 2018
Merged
boney-bun added a commit that referenced this issue Jul 2, 2018
@boney-bun
fix map functionalities (#436)
ce61f45 
* fix map functionalities
* replace the map qlr link name with the new wording in test_view
* use layer name for the zip file when download data layers in the map

fix #207
fix #390
fix #152
@gubuntu
Copy link
Author

gubuntu commented Jul 20, 2018

@boney-bun please post a screencast of the iframe working before we can close this

@boney-bun
Copy link

@gubuntu here are the screencasts:
on chrome:
geonode 152

on firefox:
geonode 152_2

unfortunately, we can't close this issue.
just found out a problem in firefox.
i'll investigate them.

@boney-bun boney-bun added ready and removed testing labels Jul 20, 2018
@boney-bun
Copy link

updating firefox to version 61.0.2 does the trick.
embed iframe works on latest firefox now:
embediframewithfirefox

i'll put this issue to the testing column.

@boney-bun boney-bun added testing and removed ready labels Aug 29, 2018
@gubuntu gubuntu closed this as completed Oct 16, 2018
@gubuntu gubuntu removed the testing label Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boney-bun boney-bun

Labels
WBExtension
Projects
None yet
Milestone
Mozambique
3 participants
@timlinux @gubuntu @boney-bun